Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the path for dds-reporting.csv #1345

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Fix the path for dds-reporting.csv #1345

merged 3 commits into from
Jan 3, 2023

Conversation

valyo
Copy link
Member

@valyo valyo commented Jan 3, 2023

Before submitting the PR, please go through the sections below and fill in what you can. If there are any items that are irrelevant for the current PR, remove the row. If a relevant option is missing, please add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

Since the reporting cron job was failing to find the csv file, see https://scilifelab.zendesk.com/agent/tickets/2645, we change the path

  • Summary of the changes and the related issue:
  • Motivation and context regarding why the change is needed:

Type of change

  • Bug fix
    • Non-breaking

"Breaking": The change will cause existing functionality to not work as expected.

Checklist:

General

  • Changelog: New row added. Not needed when PR includes only tests.
  • Code change
    • Self-review of code done

Checks

  • CodeQL passes
  • Formatting: Black & Prettier checks pass
  • Tests
    • The tests pass
  • Trivy / Snyk:
    • Security alerts have been dismissed: setuptools had a vulnerability, but the web does not use the cli in production, and setuptools is not included in the web outside of the cli

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #1345 (59e5c4a) into dev (170c3a0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1345   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files          29       29           
  Lines        4121     4121           
=======================================
  Hits         3640     3640           
  Misses        481      481           
Impacted Files Coverage Δ
dds_web/scheduled_tasks.py 77.54% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@i-oden i-oden merged commit d5a1d15 into dev Jan 3, 2023
@i-oden i-oden deleted the reporting_file_path_fix branch January 3, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants