Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cronjob for reporting #1335

Merged
merged 14 commits into from
Dec 13, 2022
Merged

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Dec 8, 2022

Before submitting the PR, please go through the sections below and fill in what you can. If there are any items that are irrelevant for the current PR, remove the row. If a relevant option is missing, please add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

Description

New cronjob for getting the number of users and units the first of each month. This is for reporting purposes and allows us to keep track of "progress".

  • Add a summary of the changes and the related issue
  • Add motivation and context regarding why the change is needed
  • Fixes DDS-1432

Type of change

  • New feature (non-breaking)

Checklist:

General

  • Changelog: New row added. Not needed when PR includes only tests.
  • Code change
    • Self-review of code done
    • Comments added, particularly in hard-to-understand areas

Repository / Releases

  • Rebase / update of branch done

Checks

  • Formatting: Black & Prettier checks pass
  • CodeQL passes
  • Tests
    • I have added tests for the new code
    • The tests pass
  • Trivy / Snyk:
    • There are no new security alerts

@i-oden i-oden self-assigned this Dec 8, 2022
@i-oden i-oden requested a review from valyo December 8, 2022 15:25
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1335 (e1ed75e) into dev (b33895c) will increase coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head e1ed75e differs from pull request most recent head 54e103f. Consider uploading reports for the commit 54e103f to get more accurate results

@@            Coverage Diff             @@
##              dev    #1335      +/-   ##
==========================================
+ Coverage   88.09%   88.21%   +0.11%     
==========================================
  Files          29       29              
  Lines        4039     4080      +41     
==========================================
+ Hits         3558     3599      +41     
  Misses        481      481              
Impacted Files Coverage Δ
dds_web/config.py 100.00% <100.00%> (ø)
dds_web/scheduled_tasks.py 77.54% <100.00%> (+6.11%) ⬆️
dds_web/security/tokens.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden
Copy link
Member Author

i-oden commented Dec 9, 2022

@valyo Tests added so this is completely ready for review now

Copy link
Member

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the two comments everything looks and works fine

dds_web/scheduled_tasks.py Outdated Show resolved Hide resolved
tests/test_scheduled_tasks.py Show resolved Hide resolved
@i-oden i-oden requested a review from valyo December 12, 2022 12:05
@i-oden
Copy link
Member Author

i-oden commented Dec 12, 2022

@valyo Could you have a look again? I changed the bit with the total number of users.

Copy link
Member

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tested again and all seems fine

@i-oden i-oden merged commit 87f2c0a into dev Dec 13, 2022
@i-oden i-oden deleted the DDS-1432-create-cronjob-for-reporting branch December 13, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants