Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint for project info #1310

Merged
merged 17 commits into from
Oct 27, 2022
Merged

Add endpoint for project info #1310

merged 17 commits into from
Oct 27, 2022

Conversation

valyo
Copy link
Member

@valyo valyo commented Oct 25, 2022

Before submitting the PR, please go through the sections below and fill in what you can. If there are any items that are irrelevant for the current PR, remove the row. If a relevant option is missing, please add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

New endpoint for displaying project information.
Works with ScilifelabDataCentre/dds_cli#561

Type of change

  • New feature (non-breaking)

Checklist:

General

  • Changelog: New row added. Not needed when PR includes only tests.
  • Code change
    • Self-review of code done
    • Comments added, particularly in hard-to-understand areas

Repository / Releases

  • Rebase / update of branch done

Checks

  • Formatting: Black & Prettier checks pass
  • CodeQL passes
  • Tests
    • I have added tests for the new code
    • The tests pass
  • Trivy / Snyk:
    • There are no new security alerts

@valyo valyo changed the title add endpoint for project info Add endpoint for project info Oct 25, 2022
@valyo valyo marked this pull request as ready for review October 25, 2022 10:00
@i-oden i-oden self-requested a review October 25, 2022 14:05
dds_web/api/project.py Outdated Show resolved Hide resolved
dds_web/api/project.py Outdated Show resolved Hide resolved
dds_web/api/project.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #1310 (ddc35a8) into dev (d3047f0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1310      +/-   ##
==========================================
+ Coverage   90.21%   90.24%   +0.03%     
==========================================
  Files          28       28              
  Lines        3741     3753      +12     
==========================================
+ Hits         3375     3387      +12     
  Misses        366      366              
Impacted Files Coverage Δ
dds_web/api/__init__.py 100.00% <100.00%> (ø)
dds_web/api/project.py 88.88% <100.00%> (+0.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Couple of tiny changes then ready to approve

tests/test_project_info_listing.py Outdated Show resolved Hide resolved
tests/test_project_info_listing.py Outdated Show resolved Hide resolved
tests/test_project_info_listing.py Show resolved Hide resolved
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 💪🏻

@i-oden i-oden merged commit f02f1bb into dev Oct 27, 2022
@i-oden i-oden deleted the DDS-1190-projectinfo_endpoint branch October 27, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants