Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add troubleshooting information to troubleshooting page #1309

Merged
merged 6 commits into from
Oct 25, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Oct 24, 2022

Before submitting the PR, please go through the sections below and fill in what you can. If there are any items that are irrelevant for the current PR, remove the row. If a relevant option is missing, please add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

Description

Updated troubleshooting document and added steps to troubleshooting page.

  • Add a summary of the changes and the related issue
  • Fixes DDS-1387

Type of change

  • Documentation

Checklist:

General

  • Changelog: New row added. Not needed when PR includes only tests.
  • Code change
    • Self-review of code done
    • Documentation is updated

Repository / Releases

  • Rebase / update of branch done

Checks

  • Formatting: Black & Prettier checks pass
  • CodeQL passes
  • Tests
    • The tests pass
  • Trivy / Snyk:
    • There are no new security alerts

@i-oden i-oden marked this pull request as draft October 24, 2022 13:57
@i-oden i-oden self-assigned this Oct 24, 2022
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #1309 (c38ed11) into dev (0d9258d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1309   +/-   ##
=======================================
  Coverage   90.21%   90.21%           
=======================================
  Files          28       28           
  Lines        3741     3741           
=======================================
  Hits         3375     3375           
  Misses        366      366           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden i-oden requested a review from valyo October 25, 2022 09:27
@i-oden i-oden marked this pull request as ready for review October 25, 2022 09:27
@i-oden
Copy link
Member Author

i-oden commented Oct 25, 2022

Merging this since we should have it in the release tomorrow --> updated troubleshooting before we go on vacation.

@i-oden i-oden merged commit aed752c into dev Oct 25, 2022
@i-oden i-oden deleted the DDS-1387-update-troubleshooting branch October 25, 2022 14:01
@i-oden i-oden removed the request for review from valyo October 25, 2022 14:01
@i-oden
Copy link
Member Author

i-oden commented Oct 25, 2022

Review is still welcome though and we can in that case change things in future releases.

Copy link
Member

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, all the links work, and it seems clear, let's hope the users get it :)

@i-oden
Copy link
Member Author

i-oden commented Oct 25, 2022

Great! Yes 🤞🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants