Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to web pages #1304

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Add version to web pages #1304

merged 4 commits into from
Oct 20, 2022

Conversation

talavis
Copy link
Contributor

@talavis talavis commented Oct 19, 2022

Before submitting the PR, please go through the sections below and fill in what you can. If there are any items that are irrelevant for the current PR, remove the row. If a relevant option is missing, please add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

Description

  • Set the version tag from GIthub to the environment variable DDS_VERSION inside the built containers
  • Add the version tag from DDS_VERSION to the footer of all web pages.

Implements DDS-1343.

  • Add a summary of the changes and the related issue
  • Fixes [link to issue / Jira issue ID]

Type of change

  • Workflow
  • New feature (non-breaking)

Checklist:

General

  • Changelog: New row added. Not needed when PR includes only tests.
  • Code change
    • Self-review of code done
    • Comments added, particularly in hard-to-understand areas

Repository / Releases

  • Rebase / update of branch done

Checks

  • Formatting: Black & Prettier checks pass
  • CodeQL passes
  • Trivy / Snyk:
    • There are no new security alerts

Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@i-oden i-oden merged commit b065a03 into dev Oct 20, 2022
@i-oden i-oden deleted the add-version branch October 20, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants