Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New endpoint for checking if any projects are busy #1288

Merged
merged 6 commits into from
Sep 26, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Sep 22, 2022

Before submitting the PR, please go through the sections below and fill in what you can. If there are any items that are irrelevant for the current PR, remove the row. If a relevant option is missing, please add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

Description

New endpoint for checking if any projects are busy so that we (super admins) can avoid maintenance while upload / download etc is ongoing.

  • Add a summary of the changes and the related issue
  • Add motivation and context regarding why the change is needed
  • Fixes DDS-1346

Type of change

  • New feature (non-breaking)

Checklist:

General

  • Changelog: New row added
  • Code change
    • Self-review of code done
    • Comments added, particularly in hard-to-understand areas

Repository / Releases

  • Blocking PRs have been merged
  • Rebase / update of branch done
  • Product Owner / Scrum Master

Checks

  • Formatting: Black & Prettier checks pass
  • CodeQL passes
  • Tests
    • I have added tests for the new code
    • The tests pass
  • Trivy / Snyk:
    • There are no new security alerts

@i-oden i-oden self-assigned this Sep 22, 2022
@i-oden i-oden requested a review from valyo September 22, 2022 11:35
@i-oden i-oden changed the title Dds 1346 endpoint for checking if any projects are busy New endpoint for checking if any projects are busy Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #1288 (01c813d) into dev (3091937) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1288      +/-   ##
==========================================
+ Coverage   87.26%   87.31%   +0.05%     
==========================================
  Files          29       29              
  Lines        3942     3958      +16     
==========================================
+ Hits         3440     3456      +16     
  Misses        502      502              
Impacted Files Coverage Δ
dds_web/api/__init__.py 100.00% <100.00%> (ø)
dds_web/api/superadmin_only.py 98.61% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden i-oden marked this pull request as ready for review September 22, 2022 14:12
Copy link
Member

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but approval can come when it works as expected with a new CLI command dds project status busy --list

@i-oden
Copy link
Member Author

i-oden commented Sep 26, 2022

Looks fine, but approval can come when it works as expected with a new CLI command dds project status busy --list

@valyo I think we can approve and merge this PR and make a new release of the CLI as well. I would prefer not changing the deployment time to Wednesday since people may have planned for it tomorrow etc. That way we only need to do a new minor CLI release when the command is done and the rest will still work.

@valyo
Copy link
Member

valyo commented Sep 26, 2022

@valyo I think we can approve and merge this PR and make a new release of the CLI as well. I would prefer not changing the deployment time to Wednesday since people may have planned for it tomorrow etc. That way we only need to do a new minor CLI release when the command is done and the rest will still work.

ok, I am approving it then

@i-oden
Copy link
Member Author

i-oden commented Sep 26, 2022

@valyo Great, thanks!

@i-oden i-oden merged commit fd9fffb into dev Sep 26, 2022
@i-oden i-oden deleted the DDS-1346-endpoint-for-checking-if-any-projects-are-busy branch September 26, 2022 13:24
@valyo valyo restored the DDS-1346-endpoint-for-checking-if-any-projects-are-busy branch August 25, 2023 14:03
@valyo valyo deleted the DDS-1346-endpoint-for-checking-if-any-projects-are-busy branch August 25, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants