Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New endpoint: Send MOTD as email #1283

Merged
merged 17 commits into from
Sep 19, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Sep 19, 2022

Before submitting the PR, please go through the sections below and fill in what you can. If there are any items that are irrelevant for the current PR, remove the row. If a relevant option is missing, please add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

Description

In order to perform maintenance or redeploy the DDS safely and avoid users performing tasks close to it, we need to be a able to inform the users of when the DDS will be down. Sometimes a MOTD unrelated to maintenance may also be very important and sending it as an email will increase the probability of one of the users reading it.

This PR adds a new endpoint which creates a connection to the email server and sends one email to each users primary email.

  • Add a summary of the changes and the related issue
  • Add motivation and context regarding why the change is needed
  • Fixes DDS-1349 (part of DDS-1326)

Type of change

  • New feature (non-breaking)

Checklist:

General

  • Changelog: New row added
  • Code change
    • Self-review of code done
    • Comments added, particularly in hard-to-understand areas

Repository / Releases

  • Blocking PRs have been merged
  • Rebase / update of branch done

Checks

  • Formatting: Black & Prettier checks pass
  • CodeQL passes
  • Tests
    • I have added tests for the new code
    • The tests pass
  • Trivy / Snyk:
    • There are no new security alerts

@i-oden i-oden marked this pull request as ready for review September 19, 2022 10:40
@i-oden i-oden requested a review from valyo September 19, 2022 10:40
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #1283 (ef5e104) into dev (040f263) will increase coverage by 0.10%.
The diff coverage is 88.88%.

❗ Current head ef5e104 differs from pull request most recent head b6124f3. Consider uploading reports for the commit b6124f3 to get more accurate results

@@            Coverage Diff             @@
##              dev    #1283      +/-   ##
==========================================
+ Coverage   87.53%   87.63%   +0.10%     
==========================================
  Files          29       29              
  Lines        3875     3907      +32     
==========================================
+ Hits         3392     3424      +32     
  Misses        483      483              
Impacted Files Coverage Δ
dds_web/utils.py 95.66% <58.33%> (-1.86%) ⬇️
dds_web/api/__init__.py 100.00% <100.00%> (ø)
dds_web/api/superadmin_only.py 100.00% <100.00%> (ø)
dds_web/api/user.py 89.23% <100.00%> (+0.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden i-oden self-assigned this Sep 19, 2022
@i-oden i-oden changed the title Dds 1349 new endpoint for sending motd as email New endpoint: Send MOTD as email Sep 19, 2022
CHANGELOG.md Show resolved Hide resolved
@i-oden i-oden merged commit bf0db18 into dev Sep 19, 2022
@i-oden i-oden deleted the DDS-1349-new-endpoint-for-sending-motd-as-email branch September 19, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants