Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to alpine #1272

Merged
merged 7 commits into from
Sep 14, 2022
Merged

Change to alpine #1272

merged 7 commits into from
Sep 14, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Sep 14, 2022

Description

Apparently some of the security scanning results are due to the docker image used. This change has been suggested for a long time and will soon be the standard for DC containers.

  • Summary of the changes and the related issue
  • Relevant motivation and context

Fixes DDS-1340

Type of change

  • Setup

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

  • New and existing unit tests pass locally with my changes

@i-oden i-oden marked this pull request as ready for review September 14, 2022 10:59
@talavis
Copy link
Contributor

talavis commented Sep 14, 2022

The changes looks fine, just wait until all tests are done to confirm that it actually works.

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1272 (39b321a) into dev (d43cf60) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1272   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files          29       29           
  Lines        3875     3875           
=======================================
  Hits         3392     3392           
  Misses        483      483           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden
Copy link
Member Author

i-oden commented Sep 14, 2022

The changes looks fine, just wait until all tests are done to confirm that it actually works.

It works locally.. Any idea on what the issue is?

@talavis
Copy link
Contributor

talavis commented Sep 14, 2022

The changes looks fine, just wait until all tests are done to confirm that it actually works.

It works locally.. Any idea on what the issue is?

Worked after rerun. Likely to be some temporary network glitch.

@i-oden i-oden merged commit 396febb into dev Sep 14, 2022
@i-oden i-oden deleted the security-alerts branch September 14, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants