Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubleshooting link change and pdf #1255

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Aug 31, 2022

Description

Please include the following in this section

  • Summary of the changes and the related issue
  • Relevant motivation and context
  • Any dependencies that are required for this change

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to
  • Changes to the database schema: A new migration is included in the PR
  • Product Owner / Scrum Master: This PR is made to the master branch and I have updated the version
  • I am bumping the major version (e.g. 1.x.x to 2.x.x) and I have made the corresponding changes to the CLI version

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@i-oden i-oden self-assigned this Aug 31, 2022
@i-oden i-oden marked this pull request as ready for review August 31, 2022 10:12
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1255 (de8c313) into dev (ec6ca9d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1255      +/-   ##
==========================================
+ Coverage   87.39%   87.44%   +0.05%     
==========================================
  Files          29       29              
  Lines        3863     3832      -31     
==========================================
- Hits         3376     3351      -25     
+ Misses        487      481       -6     
Impacted Files Coverage Δ
dds_web/web/root.py 93.54% <100.00%> (+6.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden i-oden merged commit a455a2f into dev Aug 31, 2022
@i-oden i-oden deleted the troubleshooting-link-change-and-pdf branch August 31, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant