Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt MOTD endpoint for displaying motd in cli #1198

Merged
merged 11 commits into from
Jun 17, 2022
Merged

Adapt MOTD endpoint for displaying motd in cli #1198

merged 11 commits into from
Jun 17, 2022

Conversation

valyo
Copy link
Member

@valyo valyo commented Jun 13, 2022

Adapt MOTD endpoint for displaying motd in cli

Works with ScilifelabDataCentre/dds_cli#498

Please include the following in this section

  • Summary of the changes and the related issue
  • Relevant motivation and context
  • Any dependencies that are required for this change

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to
  • Changes to the database schema: A new migration is included in the PR

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1198 (feb9563) into dev (12a0f4a) will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1198      +/-   ##
==========================================
+ Coverage   85.89%   86.18%   +0.29%     
==========================================
  Files          30       30              
  Lines        3735     3743       +8     
==========================================
+ Hits         3208     3226      +18     
+ Misses        527      517      -10     
Impacted Files Coverage Δ
dds_web/__init__.py 60.00% <100.00%> (ø)
dds_web/api/__init__.py 100.00% <100.00%> (ø)
dds_web/api/superadmin_only.py 100.00% <100.00%> (+30.30%) ⬆️
dds_web/utils.py 97.27% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a0f4a...feb9563. Read the comment docs.

@i-oden
Copy link
Member

i-oden commented Jun 13, 2022

Looks good, will test after lunch. Could you add some tests as well?

@i-oden i-oden merged commit 80e0319 into dev Jun 17, 2022
@i-oden i-oden deleted the cli_display_motd branch June 17, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants