Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display last MOTD from DB under the login form #1196

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Display last MOTD from DB under the login form #1196

merged 2 commits into from
Jun 13, 2022

Conversation

valyo
Copy link
Member

@valyo valyo commented Jun 13, 2022

Display the latest message of the day in the web
Also fixes DDS-1304

Please include the following in this section

  • Summary of the changes and the related issue
  • Relevant motivation and context
  • Any dependencies that are required for this change

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to
  • Changes to the database schema: A new migration is included in the PR

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1196 (3547144) into dev (1b4f0d8) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##              dev    #1196      +/-   ##
==========================================
- Coverage   85.90%   85.89%   -0.02%     
==========================================
  Files          30       30              
  Lines        3732     3735       +3     
==========================================
+ Hits         3206     3208       +2     
- Misses        526      527       +1     
Impacted Files Coverage Δ
dds_web/api/superadmin_only.py 69.69% <0.00%> (-2.18%) ⬇️
dds_web/web/root.py 89.47% <100.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b4f0d8...3547144. Read the comment docs.

Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the following lone to the end of the MOTD endpoint?

return {"message": "The MOTD was successfully added to the database."}

Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works.

Information for our future selves: We decided during the morning meeting that we will merge it like this so that we have the information there, and then we'll possibly change this if we come up with a better way to display it.

@i-oden i-oden merged commit 696b5c8 into dev Jun 13, 2022
@i-oden i-oden deleted the display_motd branch June 13, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants