Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fontawesome removed - needs to be fixed later when we have time #1192

Merged
merged 4 commits into from
Jun 1, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Jun 1, 2022

Description

The Fontawesome package used is a payed license which expires on Friday June 3rd. This means we need to renew this. I need to both check pricing and alternatives and also discuss the possibility of DC paying for the license. I created an account (previous link belongs to Phil), got a free link - It did not have all the icons. For now it will have to lose all the icons since I do not have time to look in to this now and need to work on a lot of other different urgent things.

  • Summary of the changes and the related issue
  • Relevant motivation and context
  • Any dependencies that are required for this change

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to
  • Changes to the database schema: A new migration is included in the PR

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@i-oden i-oden self-assigned this Jun 1, 2022
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1192 (012fb5e) into dev (081d502) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1192   +/-   ##
=======================================
  Coverage   85.76%   85.76%           
=======================================
  Files          29       29           
  Lines        3673     3673           
=======================================
  Hits         3150     3150           
  Misses        523      523           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081d502...012fb5e. Read the comment docs.

@i-oden i-oden merged commit d18cc7d into dev Jun 1, 2022
@i-oden i-oden deleted the fontawesome branch June 1, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant