Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial fix for delete_invite error DDS-1264 #1163

Merged
merged 10 commits into from
May 11, 2022
Merged

Conversation

valyo
Copy link
Member

@valyo valyo commented May 6, 2022

Fixes DDS-1264 partially; we need to make sure that we avoid invites with strange created_at date, and to handle informing the user, perhaps.

  • Tests passing
  • Black formatting
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1163 (bb4ec6a) into dev (7540974) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1163      +/-   ##
==========================================
+ Coverage   84.04%   84.05%   +0.01%     
==========================================
  Files          29       29              
  Lines        3447     3450       +3     
==========================================
+ Hits         2897     2900       +3     
  Misses        550      550              
Impacted Files Coverage Δ
dds_web/scheduled_tasks.py 71.55% <100.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7540974...bb4ec6a. Read the comment docs.

@i-oden
Copy link
Member

i-oden commented May 9, 2022

@valyo Could you add a little note in the PR description on why it's temporary?

@i-oden i-oden self-requested a review May 9, 2022 05:44
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion. Everything looks good though and it works.
Let me know if you commit the suggestion or if you want to keep it as it is now.

dds_web/scheduled_tasks.py Outdated Show resolved Hide resolved
valyo and others added 2 commits May 9, 2022 08:52
Co-authored-by: Ina Odén Österbo <[email protected]>
@i-oden
Copy link
Member

i-oden commented May 9, 2022

Btw, could we add a test for this in test_scheduled_tasks.py?

@valyo valyo changed the title temporary fix for delete_invite error DDS-1264 partial fix for delete_invite error DDS-1264 May 9, 2022
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for this (as we discussed) when you have the chance

Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@i-oden i-oden merged commit 0ea96fd into dev May 11, 2022
@i-oden i-oden deleted the DDS-1264_delete_invite_issue branch May 11, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants