-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
partial fix for delete_invite error DDS-1264 #1163
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1163 +/- ##
==========================================
+ Coverage 84.04% 84.05% +0.01%
==========================================
Files 29 29
Lines 3447 3450 +3
==========================================
+ Hits 2897 2900 +3
Misses 550 550
Continue to review full report at Codecov.
|
@valyo Could you add a little note in the PR description on why it's temporary? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion. Everything looks good though and it works.
Let me know if you commit the suggestion or if you want to keep it as it is now.
Co-authored-by: Ina Odén Österbo <[email protected]>
Btw, could we add a test for this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test for this (as we discussed) when you have the chance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fixes DDS-1264 partially; we need to make sure that we avoid invites with strange created_at date, and to handle informing the user, perhaps.
dev
branch