Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC Branding #1160

Merged
merged 4 commits into from
Apr 27, 2022
Merged

DC Branding #1160

merged 4 commits into from
Apr 27, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Apr 27, 2022

This changes the navbar again. We will now have the DC Branding at in the footer, and only the SciLifeLab logo in the navbar. The "Data Delivery System" is in text next to it.

Currently using png images in the footer because the SVG images (at least for the dark background) doesn't show the "Data Centre" part.

  • Tests passing
  • Black formatting
  • [ - ] Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@i-oden i-oden self-assigned this Apr 27, 2022
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1160 (8893d03) into dev (37a8831) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1160   +/-   ##
=======================================
  Coverage   84.05%   84.05%           
=======================================
  Files          29       29           
  Lines        3443     3443           
=======================================
  Hits         2894     2894           
  Misses        549      549           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37a8831...8893d03. Read the comment docs.

@i-oden i-oden merged commit 3b2058a into dev Apr 27, 2022
@i-oden i-oden deleted the fix-logo branch May 11, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant