-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Checks for invalid characters when creating unit #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-oden
commented
Apr 12, 2022
Codecov Report
@@ Coverage Diff @@
## dev #1154 +/- ##
==========================================
- Coverage 82.61% 82.28% -0.34%
==========================================
Files 29 29
Lines 3428 3443 +15
==========================================
+ Hits 2832 2833 +1
- Misses 596 610 +14
Continue to review full report at Codecov.
|
i-oden
added
bug
Something isn't working
backend
must have
Cannot deliver on target date without this
labels
Apr 12, 2022
talavis
suggested changes
Apr 12, 2022
talavis
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The migrations has added changes to the db that were not made in this PR, but the previous changes were not recognized by albemic before I added
compare_type=True
.dev
branch