Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Checks for invalid characters when creating unit #1154

Merged
merged 12 commits into from
Apr 13, 2022
Merged

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Apr 12, 2022

Note: The migrations has added changes to the db that were not made in this PR, but the previous changes were not recognized by albemic before I added compare_type=True.

  • Tests passing
  • Black formatting
  • [ - ] Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@i-oden i-oden self-assigned this Apr 12, 2022
dds_web/__init__.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1154 (8f786a1) into dev (67b8e86) will decrease coverage by 0.33%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##              dev    #1154      +/-   ##
==========================================
- Coverage   82.61%   82.28%   -0.34%     
==========================================
  Files          29       29              
  Lines        3428     3443      +15     
==========================================
+ Hits         2832     2833       +1     
- Misses        596      610      +14     
Impacted Files Coverage Δ
dds_web/__init__.py 47.94% <6.66%> (-2.46%) ⬇️
dds_web/database/models.py 94.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b8e86...8f786a1. Read the comment docs.

@i-oden i-oden requested a review from talavis April 12, 2022 17:05
@i-oden i-oden added bug Something isn't working backend must have Cannot deliver on target date without this labels Apr 12, 2022
dds_web/database/models.py Show resolved Hide resolved
dds_web/__init__.py Outdated Show resolved Hide resolved
@i-oden i-oden requested a review from talavis April 13, 2022 06:30
@i-oden i-oden merged commit 9c66862 into dev Apr 13, 2022
@i-oden i-oden deleted the bug-unit-name branch April 13, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working must have Cannot deliver on target date without this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants