Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Motd endpoint #1136

Merged
merged 12 commits into from
Apr 7, 2022
Merged

Add Motd endpoint #1136

merged 12 commits into from
Apr 7, 2022

Conversation

valyo
Copy link
Member

@valyo valyo commented Apr 6, 2022 •
edited by i-oden
Loading

Endpoint for MOTD.
Test with ScilifelabDataCentre/dds_cli#449

  • Tests passing
  • Black formatting
  • Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@codecov
Copy link

codecov bot commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #1136 (e44a669) into dev (981dbf2) will decrease coverage by 0.14%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##              dev    #1136      +/-   ##
==========================================
- Coverage   83.18%   83.04%   -0.15%     
==========================================
  Files          29       29              
  Lines        3367     3392      +25     
==========================================
+ Hits         2801     2817      +16     
- Misses        566      575       +9
Impacted Files Coverage Δ
dds_web/api/unit.py 71.87% <55.00%> (-28.13%) ⬇️
dds_web/api/__init__.py 100.00% <100.00%> (ø)
dds_web/database/models.py 94.26% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981dbf2...e44a669. Read the comment docs.

@valyo valyo mentioned this pull request Apr 6, 2022
Merged
4 tasks
@i-oden i-oden added the should have Important but not vital label Apr 6, 2022
i-oden
i-oden reviewed Apr 6, 2022
View reviewed changes
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of small changes

dds_web/api/unit.py Show resolved Hide resolved
dds_web/api/unit.py Outdated Show resolved Hide resolved
dds_web/database/models.py Outdated Show resolved Hide resolved
i-oden
i-oden reviewed Apr 7, 2022
View reviewed changes
dds_web/api/unit.py Outdated Show resolved Hide resolved
i-oden
i-oden approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected!

@i-oden i-oden marked this pull request as ready for review April 7, 2022 12:57
@i-oden i-oden merged commit 3142c2e into dev Apr 7, 2022
@i-oden i-oden deleted the motd-endpoint branch April 7, 2022 13:23
@i-oden
Copy link
Member

i-oden commented Apr 7, 2022

@valyo Is working on the tests in a different branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-oden i-oden i-oden approved these changes

Assignees

@valyo valyo

Labels
should have Important but not vital
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valyo @i-oden