Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduled job to change status to expired #1116

Merged
merged 18 commits into from
Apr 4, 2022
Merged

Scheduled job to change status to expired #1116

merged 18 commits into from
Apr 4, 2022

Conversation

valyo
Copy link
Member

@valyo valyo commented Mar 31, 2022 •
edited by i-oden
Loading

  • Tests passing
  • Black formatting
  • [ - ] Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • [ - ] Note in the CHANGELOG - adding in new PR

@codecov
Copy link

codecov bot commented Mar 31, 2022 •
edited
Loading

Codecov Report

Merging #1116 (527f5a8) into dev (eecf799) will decrease coverage by 0.92%.
The diff coverage is 5.12%.

@@            Coverage Diff             @@
##              dev    #1116      +/-   ##
==========================================
- Coverage   86.04%   85.12%   -0.93%     
==========================================
  Files          29       29              
  Lines        3238     3273      +35     
==========================================
  Hits         2786     2786              
- Misses        452      487      +35
Impacted Files Coverage Δ
dds_web/scheduled_tasks.py 11.62% <5.12%> (-50.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eecf799...527f5a8. Read the comment docs.

@valyo valyo marked this pull request as ready for review April 1, 2022 07:50
@i-oden i-oden added must have Cannot deliver on target date without this backend labels Apr 1, 2022
i-oden
i-oden requested changes Apr 1, 2022
View reviewed changes
dds_web/scheduled_tasks.py Outdated Show resolved Hide resolved
dds_web/scheduled_tasks.py Outdated Show resolved Hide resolved
dds_web/scheduled_tasks.py Outdated Show resolved Hide resolved
dds_web/scheduled_tasks.py Outdated Show resolved Hide resolved
dds_web/scheduled_tasks.py Outdated Show resolved Hide resolved
i-oden
i-oden reviewed Apr 4, 2022
View reviewed changes
dds_web/scheduled_tasks.py Outdated Show resolved Hide resolved
@valyo @i-oden
Update dds_web/scheduled_tasks.py
eb3a395 
Co-authored-by: Ina Odén Österbo <[email protected]>
i-oden
i-oden requested changes Apr 4, 2022
View reviewed changes
dds_web/scheduled_tasks.py Outdated Show resolved Hide resolved
dds_web/scheduled_tasks.py Outdated Show resolved Hide resolved
dds_web/scheduled_tasks.py Outdated Show resolved Hide resolved
dds_web/scheduled_tasks.py Outdated Show resolved Hide resolved
i-oden
i-oden approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@i-oden i-oden merged commit a11042a into dev Apr 4, 2022
@i-oden i-oden deleted the change-status-to-expired branch April 4, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-oden i-oden i-oden approved these changes

Assignees

@valyo valyo

Labels
backend must have Cannot deliver on target date without this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valyo @i-oden