Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add catch of OperationalError in files.py #1089

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Add catch of OperationalError in files.py #1089

merged 3 commits into from
Mar 25, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Mar 25, 2022 •
edited
Loading

  • Tests passing
  • Black formatting
  • [ - ] Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@i-oden i-oden self-assigned this Mar 25, 2022
@i-oden i-oden added database must have Cannot deliver on target date without this labels Mar 25, 2022
@i-oden i-oden mentioned this pull request Mar 25, 2022
Closed
5 tasks
@codecov
Copy link

codecov bot commented Mar 25, 2022 •
edited
Loading

Codecov Report

Merging #1089 (5c7e373) into dev (c3d9a08) will increase coverage by 0.02%.
The diff coverage is 9.52%.

@@            Coverage Diff             @@
##              dev    #1089      +/-   ##
==========================================
+ Coverage   85.96%   85.99%   +0.02%     
==========================================
  Files          28       28              
  Lines        3207     3206       -1     
==========================================
  Hits         2757     2757              
+ Misses        450      449       -1
Impacted Files Coverage Δ
dds_web/api/files.py 83.22% <9.52%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d9a08...5c7e373. Read the comment docs.

@i-oden i-oden requested a review from talavis March 25, 2022 10:46
@i-oden i-oden requested review from aanil and valyo March 25, 2022 10:49
aanil
aanil reviewed Mar 25, 2022
View reviewed changes
dds_web/api/files.py Outdated Show resolved Hide resolved
@i-oden @aanil
Update dds_web/api/files.py
5c7e373 
Co-authored-by: Anandashankar Anil <[email protected]>
@i-oden i-oden requested a review from aanil March 25, 2022 12:43
aanil
aanil approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@aanil aanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@i-oden i-oden merged commit 5a20585 into dev Mar 25, 2022
@i-oden i-oden deleted the operationalerror-in-files branch March 25, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanil aanil aanil approved these changes

@talavis talavis Awaiting requested review from talavis

@valyo valyo Awaiting requested review from valyo

Assignees

@i-oden i-oden

Labels
database must have Cannot deliver on target date without this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-oden @aanil