Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make hotp invalid after password reset #1054

Merged
merged 3 commits into from
Mar 14, 2022
Merged

make hotp invalid after password reset #1054

merged 3 commits into from
Mar 14, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Mar 14, 2022

Tested:

  1. dds auth login --> fill in username and password --> get password prompt
  2. Go to web and request password reset
  3. Reset password
  4. Use the one-time code received in the mail

This should fail. Before it was ok.

  • Tests passing
  • Black formatting
  • [ - ] Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@i-oden i-oden self-assigned this Mar 14, 2022
@i-oden i-oden added the must have Cannot deliver on target date without this label Mar 14, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@i-oden i-oden requested a review from talavis March 14, 2022 12:23
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1054 (bd44287) into dev (ccca27f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1054      +/-   ##
==========================================
+ Coverage   87.76%   87.78%   +0.01%     
==========================================
  Files          27       27              
  Lines        2975     2979       +4     
==========================================
+ Hits         2611     2615       +4     
  Misses        364      364              
Impacted Files Coverage Δ
dds_web/database/models.py 93.97% <100.00%> (+0.05%) ⬆️
dds_web/web/user.py 82.21% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccca27f...bd44287. Read the comment docs.

@i-oden i-oden merged commit 29e4a6f into dev Mar 14, 2022
@i-oden i-oden deleted the reset-hotp branch March 14, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must have Cannot deliver on target date without this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant