Modify the command dds motd send to allow the option to send only to unit personnel

[rv0lt]

Read this before submitting the PR

1. Always create a Draft PR first
2. Go through sections 1-5 below, fill them in and check all the boxes
3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Modify the client to accept the option to send only to unit persoonel

2. Jira task / GitHub issue

Link to the github issue or add the Jira task ID here.

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

• New feature
  • Breaking: Why / How? Add info here.
  • Non-breaking
• Bug fix
• Security Alert fix
  • Package update
    • Major version update
• Documentation
• Workflow
• Tests only

4. Additional information

• Sprintlog
• Blocking PRs
  • Merged
• PR to master branch: If checked, read the release instructions
  • I have followed steps 1-8.

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

• Black

• Pylint

• Prettier

• Yamllint

• Tests

• TestPyPI

• CodeQL

• Trivy

• Snyk

[valyo]

Looks good

[i-oden]

This is the same as the other PR. I will review after merge this time, but as I said I want to review tasks that have a direct affect on the users. This time I was finishing up a report before I could review.

[i-oden]

I will add a task to the product backlog regarding my comments in this PR. But also, did you check that codecov said that all lines were covered? I can't see the codecov report in this PR, so I checked the github action regarding codecov and:

[2024-10-03T09:44:34.097Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 429 - {"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 442s."}

[i-oden]

I'd rather that this option is --unit-only:

1. --unit-personnel-only partly sounds like it's only Unit Personnel who gets the email (Unit Admins should also get the email). This could cause confusion at some point.
2. --unit-personnel-only is imo unnecessarily long