Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template to include Security Alert fix details #665

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Nov 7, 2023

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Changes this PR template so that we have information about if a security alert fix is a Package update. Also removes the database change part since it's only relevant to the dds_web.

2. Jira task / GitHub issue

X

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Bug fix
  • Security Alert fix
    • Package update
      • Major version update
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Pylint
  • Prettier
  • Yamllint
  • Tests
  • TestPyPI
  • CodeQL
  • Trivy
  • Snyk

@i-oden i-oden self-assigned this Nov 7, 2023
@i-oden i-oden requested a review from a team November 7, 2023 15:27
@i-oden i-oden marked this pull request as ready for review November 7, 2023 15:27
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #665 (7b1b616) into dev (da7a2bd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #665   +/-   ##
=======================================
  Coverage   47.66%   47.66%           
=======================================
  Files          31       31           
  Lines        2887     2887           
=======================================
  Hits         1376     1376           
  Misses       1511     1511           

@i-oden
Copy link
Member Author

i-oden commented Nov 7, 2023

@valyo @rv0lt When one of you have approved this you can merge it

@rv0lt rv0lt merged commit 6b5e204 into dev Nov 8, 2023
16 checks passed
@rv0lt rv0lt deleted the update-pr-template-version branch November 8, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants