Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version and changelog #660

Merged
merged 13 commits into from
Oct 24, 2023
Merged

New version and changelog #660

merged 13 commits into from
Oct 24, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Oct 17, 2023

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Prep for new release.

2. Jira task / GitHub issue

DDS-1701

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Database change: Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix
  • Security Alert fix
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Pylint
  • Prettier
  • Yamllint
  • Tests
  • TestPyPI
  • CodeQL
  • Trivy
  • Snyk

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #660 (3aef289) into dev (eaa7e4a) will not change coverage.
Report is 1 commits behind head on dev.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #660   +/-   ##
=======================================
  Coverage   48.26%   48.26%           
=======================================
  Files          31       31           
  Lines        2851     2851           
=======================================
  Hits         1376     1376           
  Misses       1475     1475           
Files Coverage Δ
dds_cli/version.py 100.00% <100.00%> (ø)

@i-oden i-oden force-pushed the DDS-1701-new-release-for-cli branch from add84e5 to b8acc9a Compare October 17, 2023 10:12
@i-oden i-oden marked this pull request as ready for review October 24, 2023 10:43
@i-oden i-oden requested a review from a team October 24, 2023 10:43
@i-oden i-oden requested a review from rv0lt October 24, 2023 11:46
@i-oden i-oden merged commit d370e4d into dev Oct 24, 2023
17 checks passed
@i-oden i-oden deleted the DDS-1701-new-release-for-cli branch October 24, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants