-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release #659
Merged
New release #659
Changes from all commits
Commits
Show all changes
103 commits
Select commit
Hold shift + click to select a range
c096f74
added functionality
rv0lt 2bcf8be
black
rv0lt 64e8583
black
rv0lt c5b27ea
sprintlog
rv0lt 56cc6ed
tests
rv0lt 9df4ec8
black
rv0lt 21956fd
tests
rv0lt 91c0906
tests
rv0lt 4ae6af1
tests
rv0lt bf2d7fe
tests
rv0lt 63461f7
more test
rv0lt b54ef77
forgot atributes
rv0lt 5e4d662
increase coverage
rv0lt b7965a8
fix test
rv0lt b85d480
log test
rv0lt 1fea1d0
more coverage
rv0lt c6bcf77
refactoring
rv0lt cd81e61
go back
rv0lt 6c54981
go back
rv0lt a2dc1e9
init refactoring
rv0lt dac649f
init refactoring
rv0lt 8a260b3
ref
rv0lt 61ed206
typo
rv0lt 8ab5498
generalise
rv0lt faf409c
typo
rv0lt 17c8693
typo
rv0lt fc1375b
updated PR template to match the dds_web one, slightly updated
i-oden b4d4444
refactore project info
rv0lt 650c86d
forgot ddelete
rv0lt c3f5dd6
black
rv0lt 992188a
last test
rv0lt 61030a4
links
i-oden a0fc192
prettier
i-oden 1065a1c
Merge pull request #658 from ScilifelabDataCentre/update-pr-template
i-oden 9827604
feedback
rv0lt 86dfef8
added test
rv0lt 107ddaa
increase coverage
rv0lt fda09d3
Update SPRINTLOG.md
rv0lt bf23438
Update dds_cli/base.py
rv0lt ac25de6
feedback
rv0lt d1cd87b
black
rv0lt 966c5df
msg
rv0lt 46bd144
black
rv0lt 1b3c860
pylint
rv0lt ff3288d
Merge branch 'dev' into DDS-1401-Print-project-info-when-deleting-arc…
rv0lt d70a3bf
Merge pull request #655 from ScilifelabDataCentre/DDS-1401-Print-proj…
rv0lt b995218
started command
rv0lt 89c7144
second call
rv0lt c0def91
version and changelog
i-oden e31d1da
pr template
i-oden a0dcb1a
Generate new screengrabs with rich-codex
github-actions[bot] b8acc9a
prettier
i-oden 35a839e
sprintlog
i-oden 5d173a7
release docs
i-oden a4f48a7
update pr template
i-oden 1ae13a2
new release info
i-oden 0f58043
added tests
rv0lt 363f153
docstring
rv0lt 2e25400
pylint
rv0lt 4a12d23
tests!
rv0lt 9b27bda
missing test
rv0lt 7503833
missing test
rv0lt baaa98f
sprintlog
rv0lt ed779e8
prettier
rv0lt 67db194
better coments
rv0lt b8cc80b
line too long
rv0lt b045419
changed
rv0lt 17419e3
sprintlog
rv0lt 18f6a7a
Update SPRINTLOG.md
rv0lt 3364935
prettier
rv0lt 2d7cc6f
Merge pull request #662 from ScilifelabDataCentre/DDS-1697-Change-Che…
rv0lt 31fbb36
Merge branch 'dev' into DDS-1690-New-CLI-command-dds-project-status-e…
rv0lt 9167102
prettier
rv0lt f5829a0
Update SPRINTLOG.md
rv0lt fd469d7
Update dds_cli/project_status.py
rv0lt 86039bd
Update dds_cli/project_status.py
rv0lt 68d317c
Update dds_cli/project_status.py
rv0lt 0256f85
latest from dev
i-oden 12889d5
changelog
i-oden c907e48
changelog
i-oden f83a1cf
feedback
rv0lt 06949d5
pylint
rv0lt f047fb0
pylint
rv0lt 3f514d3
pylint
rv0lt c1206f7
Update dds_cli/__main__.py
rv0lt 42cd8bd
Update dds_cli/project_status.py
rv0lt ddb2db7
Update dds_cli/project_status.py
rv0lt 12ade91
Update dds_cli/project_status.py
rv0lt 693155a
feedback
rv0lt 59e42f7
Update dds_cli/project_status.py
rv0lt ff58777
Update dds_cli/project_status.py
rv0lt d81c251
Update dds_cli/project_status.py
rv0lt 61835ab
Update dds_cli/project_status.py
rv0lt 2f10d1f
feedback
rv0lt 8a20679
Update dds_cli/project_status.py
rv0lt ea57cef
black
rv0lt a47159b
Update dds_cli/project_status.py
rv0lt eaa7e4a
format date
rv0lt 932963d
Merge pull request #661 from ScilifelabDataCentre/DDS-1690-New-CLI-co…
rv0lt 431fe34
Merge branch 'dev' into DDS-1701-new-release-for-cli
i-oden 3aef289
changelog
i-oden d370e4d
Merge pull request #660 from ScilifelabDataCentre/DDS-1701-new-releas…
i-oden 871caf6
Merge branch 'master' into dev
i-oden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,79 +1,94 @@ | ||
## Before submitting this PR | ||
## Read this before submitting the PR | ||
|
||
1. **Description:** _Add a summary of the changes in this PR and the related issue._ | ||
2. **Jira task / GitHub issue:** _Link to the github issue or add the Jira task ID here._ | ||
3. **How to test:** _Add information on how someone could manually test this functionality. As detailed as possible._ | ||
4. **Type of change:** [_Check the relevant boxes in the section below_](#what-type-of-changes-does-the-pr-contain) | ||
5. **Add docstrings and comments to code**, _even if_ you personally think it's obvious. | ||
1. Always create a Draft PR first | ||
2. Go through sections 1-5 below, fill them in and check all the boxes | ||
3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch. | ||
4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right) | ||
5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review. | ||
|
||
## What _type of change(s)_ does the PR contain? | ||
If there is a field which you are unsure about, enter the edit mode of this description or go to the [PR template](https://github.com/ScilifelabDataCentre/dds_cli/blob/dev/.github/pull_request_template.md); There are invisible comments providing descriptions which may be of help. | ||
|
||
<!-- | ||
- "Breaking": The change will cause existing functionality to not work as expected. | ||
- Workflow: E.g. a new github action or changes to this PR template. Anything that alters our or the codes workflow. | ||
--> | ||
## 1. Description / Summary | ||
|
||
_Add a summary of the changes in this PR and the related issue._ | ||
|
||
## 2. Jira task / GitHub issue | ||
|
||
_Link to the github issue or add the Jira task ID here._ | ||
|
||
## 3. Type of change | ||
|
||
What _type of change(s)_ does the PR contain? | ||
|
||
**Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.** | ||
|
||
- [ ] New feature | ||
- [ ] Breaking: _Please describe the reason for the break and how we can fix it._ | ||
- [ ] Non-breaking | ||
- [ ] Bug fix | ||
- [ ] Breaking: _Please describe the reason for the break and how we can fix it._ | ||
- [ ] Non-breaking | ||
- [ ] Security Alert fix | ||
- [ ] Documentation | ||
- [ ] Tests **(only)** | ||
- [ ] Workflow | ||
|
||
## Checklist | ||
|
||
- [Sprintlog](../SPRINTLOG.md) | ||
- [ ] Added | ||
- [ ] Not needed (E.g. PR contains _only_ tests) | ||
- Rebase / Update / Merge _from_ base branch (the branch from which the current is forked) | ||
- [ ] Done | ||
- [ ] Not needed | ||
- Blocking PRs | ||
- [ ] Merged | ||
- [ ] No blocking PRs | ||
- PR to `master` branch | ||
- [ ] Yes: Read [the release instructions](../docs/procedures/new_release.md) | ||
- [ ] I have followed steps 1-7. | ||
- [ ] No | ||
|
||
## Actions / Scans | ||
|
||
<!-- Go through all checkboxes. All actions must pass before merging is allowed.--> | ||
|
||
- **Black**: Python code formatter. Does not execute. Only tests. | ||
Run `black .` locally to execute formatting. | ||
- [ ] Passed | ||
- **Pylint**: Python code linter. Does not execute. Only tests. | ||
Fix code producing warnings. Code must get 10/10. | ||
- [ ] Warnings fixed | ||
- [ ] Passed | ||
- **Prettier**: General code formatter. Our use case: MD and yaml mainly. | ||
Run `npx prettier --write .` locally to execute formatting. | ||
- [ ] Passed | ||
- **Yamllint**: Linting of yaml files. | ||
- [ ] Passed | ||
- **Tests**: Pytest to verify that functionality works as expected. | ||
- [ ] New tests added | ||
- [ ] No new tests | ||
- [ ] Passed | ||
- **TestPyPi**: Build CLI and publish to TestPyPi in order to verify before release. | ||
- [ ] Passed | ||
- **CodeQL**: Scan for security vulnerabilities, bugs, errors | ||
- [ ] New alerts: _Go through them and either fix, dismiss och ignore. Add reasoning in items below._ | ||
- [ ] Alerts fixed: _What?_ | ||
- [ ] Alerts ignored / dismissed: _Why?_ | ||
- [ ] Passed | ||
- **Trivy**: Security scanner | ||
- [ ] New alerts: _Go through them and either fix, dismiss och ignore. Add reasoning in items below._ | ||
- [ ] Alerts fixed: _What?_ | ||
- [ ] Alerts ignored / dismissed: _Why?_ | ||
- [ ] Passed | ||
- **Snyk**: Security scanner | ||
- [ ] New alerts: _Go through them and either fix, dismiss och ignore. Add reasoning in items below._ | ||
- [ ] Alerts fixed: _What?_ | ||
- [ ] Alerts ignored / dismissed: _Why?_ | ||
- [ ] Passed | ||
- [ ] Breaking: _Why / How? Add info here._ <!-- Should be checked if the changes in this PR will cause existing functionality to not work as expected. E.g. with the master branch of the `dds_cli` --> | ||
- [ ] Non-breaking <!-- Should be checked if the changes will not cause existing functionality to fail. "Non-breaking" is just an addition of a new feature. --> | ||
- [ ] Database change: _Remember the to include a new migration version, **or** explain here why it's not needed._ <!-- Should be checked when you've changed something in `models.py`. For a guide on how to add the a new migration version, look at the "Database changes" section in the README.md. --> | ||
- [ ] Bug fix <!-- Should be checked when a bug is fixed in existing functionality. If the bug fix also is a breaking change (see above), add info about that beside this check box. --> | ||
- [ ] Security Alert fix <!-- Should be checked if the PR attempts to solve a security vulnerability, e.g. reported by the "Security" tab in the repo. --> | ||
- [ ] Documentation <!-- Should be checked if the PR adds or updates the CLI documentation -- anything in docs/ directory. --> | ||
- [ ] Workflow <!-- Should be checked if the PR includes a change in e.g. the github actions files (dds_cli/.github/*) or another type of workflow change. Anything that alters our or the codes workflow. --> | ||
- [ ] Tests **only** <!-- Should only be checked if the PR only contains tests, none of the other types of changes listed above. --> | ||
|
||
## 4. Additional information | ||
|
||
- [ ] [Sprintlog](https://github.com/ScilifelabDataCentre/dds_cli/blob/dev/SPRINTLOG.md) <!-- Add a row at the bottom of the SPRINTLOG.md file (not needed if PR contains only tests). Follow the format of previous rows. If the PR is the first in a new sprint, add a new sprint header row (follow the format of previous sprints). --> | ||
- [ ] Blocking PRs <!-- Should be checked if there are blocking PRs or other tasks that need to be merged prior to this. Add link to PR or Jira card if this is the case. --> | ||
- [ ] Merged <!-- Should be checked if the "Blocking PRs" box was checked AND all blocking PRs have been merged / fixed. --> | ||
- [ ] PR to `master` branch: _If checked, read [the release instructions](https://github.com/ScilifelabDataCentre/dds_cli/blob/dev/docs/procedures/new_release.md)_ <!-- Check this if the PR is made to the `master` branch. Only the `dev` branch should be doing this. --> | ||
- [ ] I have followed steps 1-8. <!-- Should be checked if the "PR to `master` branch" box is checked AND the specified steps in the release instructions have been followed. --> | ||
|
||
## 5. Actions / Scans | ||
|
||
_Check the boxes when the specified checks have passed._ | ||
|
||
**For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the [PR template](https://github.com/ScilifelabDataCentre/dds_cli/blob/dev/.github/pull_request_template.md).** | ||
|
||
- [ ] **Black** | ||
<!-- | ||
What: Python code formatter. | ||
How to fix: Run `black .` locally to execute formatting. | ||
--> | ||
- [ ] **Pylint** | ||
<!-- | ||
What: Python code linter. | ||
How to fix: Manually fix the code producing warnings. Code must get 10/10. | ||
--> | ||
- [ ] **Prettier** | ||
<!-- | ||
What: General code formatter. Our use case: MD and yaml mainly. | ||
How to fix: Run npx prettier --write . locally to execute formatting. | ||
--> | ||
- [ ] **Yamllint** | ||
<!-- | ||
What: Linting of yaml files. | ||
How to fix: Manually fix any errors locally. | ||
--> | ||
- [ ] **Tests** | ||
<!-- | ||
What: Pytest to verify that functionality works as expected. | ||
How to fix: Manually fix any errors locally. Follow the instructions in the "Run tests" section of the README.md to run the tests locally. | ||
Additional info: The PR should ALWAYS include new tests or fixed tests when there are code changes. When pytest action has finished, it will post a codecov report; Look at this report and verify the files you have changed are listed. "90% <100.00%> (+0.8%)" means "Tests cover 90% of the changed file, <100 % of this PR's code changes are tested>, and (the code changes and added tests increased the overall test coverage with 0.8%) | ||
--> | ||
- [ ] **TestPyPI** | ||
<!-- | ||
What: Builds the CLI and publishes to TestPyPI in order to verify before release. | ||
How to fix: Check the action logs and fix potential issues manually. | ||
--> | ||
- [ ] **CodeQL** | ||
<!-- | ||
What: Scan for security vulnerabilities, bugs, errors. | ||
How to fix: Go through the alerts and either manually fix, dismiss or ignore. Add info on ignored or dismissed alerts. | ||
--> | ||
- [ ] **Trivy** | ||
<!-- | ||
What: Security scanner. | ||
How to fix: Go through the alerts and either manually fix, dismiss or ignore. Add info on ignored or dismissed alerts. | ||
--> | ||
- [ ] **Snyk** | ||
<!-- | ||
What: Security scanner. | ||
How to fix: Go through the alerts and either manually fix, dismiss or ignore. Add info on ignored or dismissed alerts. | ||
--> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will result in:
ERROR Failed to extend project deadline: The method is not allowed for the requested URL.
when run with the
master
branch of thedds_web