Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PR template to simplify and match dds_web #658

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Sep 28, 2023

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Updates PR template to this one.

2. Jira task / GitHub issue

X

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Database change: Remember the to include a new migration version, or explain here why it's not needed.
  • Bug fix
  • Security Alert fix
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

Check the boxes when the specified checks have passed.

For information on what the different checks do and how to fix it if they're failing, enter edit mode of this description or go to the PR template.

  • Black
  • Pylint
  • Prettier
  • Yamllint
  • Tests
  • TestPyPI
  • CodeQL
  • Trivy
  • Snyk

@i-oden i-oden self-assigned this Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #658 (a0fc192) into dev (799edac) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #658      +/-   ##
==========================================
- Coverage   46.74%   46.63%   -0.11%     
==========================================
  Files          31       31              
  Lines        2792     2792              
==========================================
- Hits         1305     1302       -3     
- Misses       1487     1490       +3     

see 1 file with indirect coverage changes

@i-oden i-oden marked this pull request as ready for review September 28, 2023 10:09
@i-oden i-oden merged commit 1065a1c into dev Sep 28, 2023
15 checks passed
@i-oden i-oden deleted the update-pr-template branch September 28, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant