Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.5.1 and changelog #654

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Sep 22, 2023

Read this before submitting the PR

  1. Always create a Draft PR first
  2. Go through sections 1-5 below, fill them in and check all the boxes
  3. Make sure that the branch is updated; if there's an "Update branch" button at the bottom of the PR, rebase or update branch.
  4. When all boxes are checked, information is filled in, and the branch is updated: mark as Ready For Review and tag reviewers (top right)
  5. Once there is a submitted review, implement the suggestions (if reasonable, otherwise discuss) and request an new review.

If there is a field which you are unsure about, enter the edit mode of this description or go to the PR template; There are invisible comments providing descriptions which may be of help.

1. Description / Summary

Change version to 2.5.1 and update changelog.

2. Jira task / GitHub issue

DDS-1635

3. Type of change

What type of change(s) does the PR contain?

Check the relevant boxes below. For an explanation of the different sections, enter edit mode of this PR description template.

  • New feature
    • Breaking: Why / How? Add info here.
    • Non-breaking
  • Bug fix
  • Security Alert fix
  • Documentation
  • Workflow
  • Tests only

4. Additional information

5. Actions / Scans

  • Black: Python code formatter. Does not execute. Only tests.
    Run black . locally to execute formatting.
    • Passed
  • Pylint: Python code linter. Does not execute. Only tests.
    Fix code producing warnings. Code must get 10/10.
    • Warnings fixed
    • Passed
  • Prettier: General code formatter. Our use case: MD and yaml mainly.
    Run npx prettier --write . locally to execute formatting.
    • Passed
  • Yamllint: Linting of yaml files.
    • Passed
  • Tests: Pytest to verify that functionality works as expected.
    • New tests added
    • No new tests
    • Passed
  • TestPyPi: Build CLI and publish to TestPyPi in order to verify before release.
    • Passed
  • CodeQL: Scan for security vulnerabilities, bugs, errors
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Trivy: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Snyk: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed

@i-oden i-oden self-assigned this Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #654 (3cd9551) into dev (0daaff2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #654   +/-   ##
=======================================
  Coverage   46.74%   46.74%           
=======================================
  Files          31       31           
  Lines        2792     2792           
=======================================
  Hits         1305     1305           
  Misses       1487     1487           
Files Changed Coverage Δ
dds_cli/version.py 100.00% <100.00%> (ø)

@i-oden i-oden force-pushed the DDS-1635-maintenance-2023-09-27-release-api-and-cli branch from c6a22a5 to 3cd9551 Compare September 22, 2023 11:57
@i-oden i-oden marked this pull request as ready for review September 22, 2023 12:05
@i-oden i-oden requested a review from a team September 22, 2023 12:06
@rv0lt
Copy link
Member

rv0lt commented Sep 25, 2023

imagen

Should this be marked ?

@i-oden
Copy link
Member Author

i-oden commented Sep 25, 2023

imagen

Should this be marked ?

No only in the PRs from dev to master

@rv0lt
Copy link
Member

rv0lt commented Sep 25, 2023

imagen
Should this be marked ?

No only in the PRs from dev to master

Ah, yes. I got confussed with the other PR 🤦

@i-oden
Copy link
Member Author

i-oden commented Sep 25, 2023

imagen
Should this be marked ?

No only in the PRs from dev to master

Ah, yes. I got confussed with the other PR 🤦

Understandable!

Copy link
Member

@rv0lt rv0lt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont' see anything weird

@i-oden i-oden merged commit 358463d into dev Sep 25, 2023
18 checks passed
@i-oden i-oden deleted the DDS-1635-maintenance-2023-09-27-release-api-and-cli branch September 25, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants