-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dds 1473 GitHub Actions not able to generate the documentation #650
Dds 1473 GitHub Actions not able to generate the documentation #650
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #650 +/- ##
==========================================
+ Coverage 46.63% 46.74% +0.10%
==========================================
Files 31 31
Lines 2792 2792
==========================================
+ Hits 1302 1305 +3
+ Misses 1490 1487 -3 |
The build won't work unless there is a release due to this parameter: upload_url: ${{ github.event.release.upload_url }} However, the fails that were occurring before that point are solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I just have a couple of questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also add a sprintlog row btw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job solving this! Approved, you can merge
It says The base branch restricts merging to authorized users |
Aha.. Interesting. I'll merge then, and check if we have different settings for the |
Before submitting this PR
What type of change(s) does the PR contain?
Checklist
master
branchActions / Scans
Run
black .
locally to execute formatting.Fix code producing warnings. Code must get 10/10.
Run
npx prettier --write .
locally to execute formatting.