-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the dds stats
command to get the rows from Statistics
endpoint
#643
Merged
i-oden
merged 40 commits into
dev
from
DDS-1575-update-dds-stats-command-to-get-latest-reporting-row
Sep 12, 2023
Merged
Update the dds stats
command to get the rows from Statistics
endpoint
#643
i-oden
merged 40 commits into
dev
from
DDS-1575-update-dds-stats-command-to-get-latest-reporting-row
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #643 +/- ##
==========================================
+ Coverage 46.30% 46.63% +0.32%
==========================================
Files 31 31
Lines 2790 2792 +2
==========================================
+ Hits 1292 1302 +10
+ Misses 1498 1490 -8
|
Tests and fixes of the failed checks needed |
valyo
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine and the local tests pass
i-oden
deleted the
DDS-1575-update-dds-stats-command-to-get-latest-reporting-row
branch
September 12, 2023 09:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR
dds stats
was run. Now, there's a new endpoint which gets the statistics from the reporting table and returns all rows. This PR updates thedds stats
command to return those rows and print them as tables.What type of change(s) does the PR contain?
Checklist
master
branchActions / Scans
Run
black .
locally to execute formatting.Fix code producing warnings. Code must get 10/10.
Run
npx prettier --write .
locally to execute formatting.