Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version and change to pyinstaller for all but windows #612

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Feb 10, 2023

New release: 2.2.61, for ubuntu 20.04

1. This PR contains the following changes...

Seems PyInstaller was the correct command for Windows, but not for the rest. Changing back. And since we need to make a new release, bumping version.

2. The following additional changes are required for this to work

X

3. The PR fixes the following GitHub issue / Jira task

4. What type of change(s) does the PR contain?

  • New feature
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Bug fix
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Security Alert fix
  • Documentation
  • Tests (only)
  • Workflow

5. Checklist

Always

  • Changelog
    • Added
    • Not needed (E.g. PR contains only tests)
  • Rebase / Update / Merge from base branch (the branch from which the current is forked)
    • Done
    • Not needed
  • Blocking PRs
    • Merged
    • No blocking PRs
  • PR to master branch

If PR consists of code change(s)

  • Self review
    • Done
  • Comments, docstrings, etc
    • Added / Updated
  • Documentation
    • Updated
    • Update not needed

6. Actions / Scans

  • Black: Python code formatter. Does not execute. Only tests.
    Run black . locally to execute formatting.
    • Passed
  • Prettier: General code formatter. Our use case: MD and yaml mainly.
    Run npx prettier --write . locally to execute formatting.
    • Passed
  • Yamllint: Linting of yaml files.
    • Passed
  • Tests: Pytest to verify that functionality works as expected.
    • New tests added
    • No new tests
    • Passed
  • TestPyPi: Build CLI and publish to TestPyPi in order to verify before release.
    • Passed
  • CodeQL: Scan for security vulnerabilities, bugs, errors
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Trivy: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Snyk: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed

@i-oden i-oden self-assigned this Feb 10, 2023
@i-oden i-oden marked this pull request as ready for review February 10, 2023 13:05
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #612 (fa3a1c2) into dev (f86014a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head fa3a1c2 differs from pull request most recent head 373b9bf. Consider uploading reports for the commit 373b9bf to get more accurate results

@@           Coverage Diff           @@
##              dev     #612   +/-   ##
=======================================
  Coverage   46.68%   46.68%           
=======================================
  Files          31       31           
  Lines        2787     2787           
=======================================
  Hits         1301     1301           
  Misses       1486     1486           
Impacted Files Coverage Δ
dds_cli/version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden i-oden merged commit e5c0798 into dev Feb 10, 2023
@i-oden i-oden deleted the new-version branch February 10, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant