Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan CLI code with snyk #593

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Scan CLI code with snyk #593

merged 3 commits into from
Jan 18, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Jan 10, 2023

Before submitting the PR

  • Fill in and tick fields
  • Remove all rows that are not relevant for the current PR
    • Revelant option missing? Add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

Description

  • Summary of the changes and the related issue: Add Snyk code scanning IaC as a github action to increase code scanning tools for API and CLI.
  • Fixes an issue in GitHub / Jira:
    • Yes: DDS-1442

Type of change

  • Workflow

Checklist:

General

  • Changelog: New row added. Not needed when PR includes only tests.

Repository / Releases

  • Rebase / update of branch done

Checks

  • CodeQL passes
  • Snyk scan passes
  • Formatting: Black & Prettier checks pass
  • Tests
    • The tests pass
  • Trivy:
    • There are no new security alerts

@i-oden i-oden self-assigned this Jan 10, 2023
@i-oden i-oden requested a review from valyo January 10, 2023 12:38
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #593 (fd277ed) into dev (3165870) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #593   +/-   ##
=======================================
  Coverage   46.68%   46.68%           
=======================================
  Files          31       31           
  Lines        2787     2787           
=======================================
  Hits         1301     1301           
  Misses       1486     1486           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden i-oden merged commit e0c9e0e into dev Jan 18, 2023
@i-oden i-oden deleted the snyk-scan branch January 18, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants