Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New minor release for (part of) Windows bug #574

Merged
merged 23 commits into from
Nov 29, 2022
Merged

New minor release for (part of) Windows bug #574

merged 23 commits into from
Nov 29, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Nov 29, 2022

Before submitting the PR, please go through the sections below and fill in what you can. If there are any items that are irrelevant for the current PR, remove the row. If a relevant option is missing, please add it as an item and add a PR comment informing that the new option should be included into this template.

All relevant items should be ticked before the PR is merged

Description

Fixes the Windows bug for new uploads.

  • Add a summary of the changes and the related issue

Type of change

  • Bug fix (non-breaking)

Checklist:

General

  • Changelog: New row added. Not needed when PR includes only tests.
  • Code change
    • Self-review of code done
    • Comments added, particularly in hard-to-understand areas
    • Documentation is updated

Repository / Releases

  • Rebase / update of branch done
  • PR to master branch (Product Owner / Scrum Master)

Checks

  • Formatting: Black & Prettier checks pass
  • CodeQL passes
  • Tests
    • The tests pass

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #574 (fad70dd) into master (4643110) will increase coverage by 0.09%.
The diff coverage is 73.07%.

@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
+ Coverage   45.26%   45.36%   +0.09%     
==========================================
  Files          29       29              
  Lines        2629     2641      +12     
==========================================
+ Hits         1190     1198       +8     
- Misses       1439     1443       +4     
Impacted Files Coverage Δ
dds_cli/data_putter.py 22.96% <ø> (ø)
dds_cli/data_lister.py 14.02% <33.33%> (+0.39%) ⬆️
dds_cli/__main__.py 41.47% <50.00%> (-0.38%) ⬇️
dds_cli/file_handler.py 42.37% <66.66%> (+0.70%) ⬆️
dds_cli/file_handler_local.py 58.49% <75.00%> (+0.39%) ⬆️
dds_cli/utils.py 97.40% <83.33%> (-0.97%) ⬇️
dds_cli/options.py 100.00% <100.00%> (ø)
dds_cli/version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden i-oden marked this pull request as ready for review November 29, 2022 07:35
@i-oden i-oden requested a review from valyo November 29, 2022 07:35
@i-oden i-oden self-assigned this Nov 29, 2022
@i-oden i-oden merged commit efbd817 into master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants