Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased timeout variable to 120 seconds #508

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Increased timeout variable to 120 seconds #508

merged 1 commit into from
Aug 2, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Aug 2, 2022

Description

HTTPConnectionPool - time out. Increased the timeout. Probably need to look at why the connection is taking so long.

  • Summary of the changes and the related issue
  • Relevant motivation and context
  • Any dependencies that are required for this change

Fixes X

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to
  • Product Owner / Scrum Master: This PR is made to the master branch and I have updated the version

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@i-oden i-oden added the bug Something isn't working label Aug 2, 2022
@i-oden i-oden self-assigned this Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #508 (6dd2194) into dev (e4fab4c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #508   +/-   ##
=======================================
  Coverage   41.44%   41.44%           
=======================================
  Files          29       29           
  Lines        2531     2531           
=======================================
  Hits         1049     1049           
  Misses       1482     1482           
Impacted Files Coverage Δ
dds_cli/__init__.py 90.78% <100.00%> (ø)
dds_cli/version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@i-oden i-oden merged commit 8342202 into dev Aug 2, 2022
@i-oden i-oden deleted the increase-timeout branch August 2, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant