Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change message #500

Merged
merged 3 commits into from
Jun 27, 2022
Merged

change message #500

merged 3 commits into from
Jun 27, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Jun 27, 2022

Description

Changed the message from

unable to confirm whether file permissions are correct on windows

to

Storing the login information locally - please ensure no one else an access the file at

due to previous message confusing the users - sounds like something is wrong but it's only that there is a check regarding the token permissions that cannot be performed on windows.

  • Summary of the changes and the related issue
  • Relevant motivation and context
  • Any dependencies that are required for this change

Fixes DDS-1310

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to
  • Product Owner / Scrum Master: This PR is made to the master branch and I have updated the version

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

Tested on Windows.

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #500 (49bacd3) into dev (98ef2dc) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #500   +/-   ##
=======================================
  Coverage   11.27%   11.27%           
=======================================
  Files          29       29           
  Lines        2502     2502           
=======================================
  Hits          282      282           
  Misses       2220     2220           
Impacted Files Coverage Δ
dds_cli/user.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98ef2dc...49bacd3. Read the comment docs.

@i-oden i-oden self-assigned this Jun 27, 2022
@i-oden i-oden merged commit 1743bdb into dev Jun 27, 2022
@i-oden i-oden deleted the DDS-1310_change-windows-token-message branch June 27, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant