Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor post request from project_creator #482

Merged
merged 6 commits into from
May 4, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented May 4, 2022

This requires the following follow up task: https://scilifelab.atlassian.net/browse/DDS-1271?atlOrigin=eyJpIjoiMmQ4NGFlYmRhMDdkNDc1NDgxMzk2MTBlYzRmMmUzZjEiLCJwIjoiaiJ9

Before submitting a PR to the dev branch:

  • Tests passing
  • Black formatting
  • Rebase/merge the dev branch

Additional checks before submitting a PR to the master branch:

  • Change version in dds_cli/version.py (?)

@i-oden i-oden self-assigned this May 4, 2022
@i-oden i-oden requested a review from valyo May 4, 2022 06:29
@i-oden i-oden force-pushed the DDS-1268_refactor_project_creator_post_request branch from d689490 to cb01b4f Compare May 4, 2022 10:08
Copy link
Member

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes for consistency, otherwise looks good

dds_cli/project_creator.py Outdated Show resolved Hide resolved
dds_cli/project_creator.py Outdated Show resolved Hide resolved
@i-oden i-oden merged commit 4c234ee into dev May 4, 2022
@i-oden i-oden deleted the DDS-1268_refactor_project_creator_post_request branch May 4, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants