Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "requests.delete/post" in "account_manager.py" with the "perform_request" function from "utils.py" #479

Merged
merged 7 commits into from
May 4, 2022
Merged

Replace "requests.delete/post" in "account_manager.py" with the "perform_request" function from "utils.py" #479

merged 7 commits into from
May 4, 2022

Conversation

valyo
Copy link
Member

@valyo valyo commented May 3, 2022 •
edited by i-oden
Loading

Before submitting a PR to the dev branch:

  • Tests passing
  • Black formatting
  • Rebase/merge the dev branch

Additional checks before submitting a PR to the master branch:

  • Change version in dds_cli/version.py (?)

valyo
valyo commented May 3, 2022
View reviewed changes
dds_cli/account_manager.py Outdated Show resolved Hide resolved
@i-oden i-oden self-requested a review May 3, 2022 13:27
i-oden
i-oden requested changes May 3, 2022
View reviewed changes
Copy link
Member

@i-oden i-oden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of add_user first, basically just some code that we need to remove and then add at a later point again

dds_cli/account_manager.py Outdated Show resolved Hide resolved
dds_cli/account_manager.py Outdated Show resolved Hide resolved
dds_cli/account_manager.py Outdated Show resolved Hide resolved
i-oden
i-oden reviewed May 3, 2022
View reviewed changes
dds_cli/account_manager.py Outdated Show resolved Hide resolved
i-oden
i-oden reviewed May 3, 2022
View reviewed changes
dds_cli/account_manager.py Outdated Show resolved Hide resolved
i-oden
i-oden reviewed May 3, 2022
View reviewed changes
dds_cli/account_manager.py Outdated Show resolved Hide resolved
i-oden
i-oden reviewed May 3, 2022
View reviewed changes
dds_cli/account_manager.py Outdated Show resolved Hide resolved
i-oden
i-oden reviewed May 3, 2022
View reviewed changes
dds_cli/account_manager.py Outdated Show resolved Hide resolved
i-oden
i-oden reviewed May 3, 2022
View reviewed changes
dds_cli/account_manager.py Outdated Show resolved Hide resolved
i-oden
i-oden reviewed May 3, 2022
View reviewed changes
dds_cli/account_manager.py Outdated Show resolved Hide resolved
i-oden
i-oden approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seems to work well. Needs follow up task as previously mentioned: https://scilifelab.atlassian.net/browse/DDS-1265?atlOrigin=eyJpIjoiYWM4OTE4YmVkOTIyNDk4NWEzMDZjZTg1ZjA1MTczM2QiLCJwIjoiaiJ9

@i-oden i-oden merged commit 39da177 into dev May 4, 2022
@i-oden i-oden deleted the DDS-1256_refactor_req_acc_manager branch May 4, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-oden i-oden i-oden approved these changes

Assignees

@valyo valyo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valyo @i-oden