Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "requests.get" in "user.py" with the "request_get" function from "utils.py" #475

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Replace "requests.get" in "user.py" with the "request_get" function from "utils.py" #475

merged 2 commits into from
Apr 26, 2022

Conversation

valyo
Copy link
Member

@valyo valyo commented Apr 25, 2022 •
edited by i-oden
Loading

Before submitting a PR to the dev branch:

  • Tests passing
  • Black formatting
  • Rebase/merge the dev branch
  • [ - ] Note in the CHANGELOG

Additional checks before submitting a PR to the master branch:

  • Change version in dds_cli/version.py (?)

i-oden
i-oden approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested?

@i-oden i-oden merged commit 4516e59 into dev Apr 26, 2022
@i-oden i-oden deleted the DDS-1247_refactor_user branch April 26, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-oden i-oden i-oden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valyo @i-oden