Replace "requests.get" with the "request_get" function #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-oden
requested changes
Apr 21, 2022
There was a problem hiding this comment.
Change in function name and also need to refactor the end of the function: https://github.com/ScilifelabDataCentre/dds_cli/pull/463/files#diff-51fea701513da58b2a0a4b204b195162b68d9f5f57e782277cc4365d4944a0f6R155-R175
if not response.ok:
etc is already checked by request_get and what's returned by the function is already in json.
valyo
reviewed
Apr 21, 2022
i-oden
requested changes
Apr 21, 2022
i-oden
requested changes
Apr 21, 2022
i-oden
reviewed
Apr 21, 2022
added 2 commits
April 21, 2022 14:11
This patch replaces "requests.get" with the "request_get" function in "utils.py". Fixes DDS-1236. Signed-off-by: Zishan Mirza <[email protected]>
Signed-off-by: Zishan Mirza <[email protected]>
i-oden
approved these changes
Apr 22, 2022
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces "requests.get" with the "request_get" function in "utils.py".
Fixes DDS-1236.
Before submitting a PR to the
devbranch:devbranch