Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change json response #451

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Change json response #451

merged 2 commits into from
Apr 8, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Apr 8, 2022 •
edited
Loading

Changed to just getting the json response once instead of everytime it's used, removed the unnecessary else and the try/except block at the end of creating project.

Before submitting a PR to the dev branch:

  • Tests passing
  • Black formatting
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

Additional checks before submitting a PR to the master branch:

  • Change version in dds_cli/version.py (?)

@i-oden i-oden added the should have Important but not vital label Apr 8, 2022
@i-oden i-oden self-assigned this Apr 8, 2022
@i-oden i-oden merged commit 35bd8d6 into dev Apr 8, 2022
@i-oden i-oden deleted the fix-error-mess branch April 8, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@i-oden i-oden

Labels
should have Important but not vital
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@i-oden