Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project access error message #379

Merged
merged 13 commits into from
Mar 14, 2022
Merged

Fix project access error message #379

merged 13 commits into from
Mar 14, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Mar 10, 2022 •
edited
Loading

Print out which projects a user could not give access to and the errors. Should be used with ScilifelabDataCentre/dds_web#1045

Before submitting a PR to the dev branch:

  • Tests passing
  • Black formatting
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

Additional checks before submitting a PR to the master branch:

  • Change version in setup.py (?)

@i-oden i-oden self-assigned this Mar 10, 2022
@i-oden i-oden added the must have Cannot deliver on target date without this label Mar 10, 2022
@i-oden i-oden mentioned this pull request Mar 10, 2022
Merged
3 tasks
i-oden
i-oden commented Mar 10, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
MatthiasZepper
MatthiasZepper approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@MatthiasZepper MatthiasZepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Collapsing multiple keys for unique errors will give a much better UX!

dds_cli/account_manager.py Outdated Show resolved Hide resolved
@i-oden
Copy link
Member Author

i-oden commented Mar 11, 2022

I know that there's some duplication, will change this at some point, now I just need it to give an understandable message.

MatthiasZepper
MatthiasZepper approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@MatthiasZepper MatthiasZepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. One minor thing that I don't understand, but nothing that would preclude approval.

dds_cli/account_manager.py Outdated Show resolved Hide resolved
dds_cli/account_manager.py Outdated Show resolved Hide resolved
@i-oden i-oden requested a review from talavis March 13, 2022 11:25
talavis
talavis approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@talavis talavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other non-related bugs found during testing, but the code covered here seems to work as intended.

@i-oden i-oden merged commit dd8c079 into dev Mar 14, 2022
@i-oden i-oden deleted the fix-internal-server-error branch March 14, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talavis talavis talavis approved these changes

@MatthiasZepper MatthiasZepper MatthiasZepper approved these changes

Assignees

@i-oden i-oden

Labels
must have Cannot deliver on target date without this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i-oden @talavis @MatthiasZepper