Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for zero-conf dev environment to the cli #337

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Add support for zero-conf dev environment to the cli #337

merged 3 commits into from
Mar 4, 2022

Conversation

talavis
Copy link
Contributor

@talavis talavis commented Mar 4, 2022 •
edited by i-oden
Loading

Should be combined with pr #933 from dds_web.

Before submitting a PR to the dev branch:

  • Tests passing
  • Black formatting
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

Additional checks before submitting a PR to the master branch:

  • Change version in setup.py (?)

@talavis talavis mentioned this pull request Mar 4, 2022
Merged
3 tasks
@i-oden i-oden added the must have Cannot deliver on target date without this label Mar 4, 2022
@i-oden i-oden self-requested a review March 4, 2022 07:21
i-oden
i-oden approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

alneberg
alneberg approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@i-oden i-oden merged commit 65e329e into dev Mar 4, 2022
@talavis talavis deleted the dev-support branch March 4, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alneberg alneberg alneberg approved these changes

@i-oden i-oden i-oden approved these changes

Assignees

@talavis talavis

Labels
must have Cannot deliver on target date without this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@talavis @alneberg @i-oden