Skip to content

Conversation

@jamesp
Copy link
Member

@jamesp jamesp commented May 4, 2021

This adds a new version of the anomaly plot, added to imagerepo.json in SciTools/iris#4108.

I hope I have done this correctly, please let me know if not

@trexfeathers trexfeathers self-requested a review May 4, 2021 13:10
@trexfeathers trexfeathers self-assigned this May 4, 2021
@rcomer
Copy link
Member

rcomer commented May 4, 2021

I think that linscale should have been set to 0.1 rather than 1. This way the scale looks more sensible to me, and closer to what is in our stable docs.

anomalylog

This setting doesn't get the test passing though, so we would need new hashes regardless!

@trexfeathers
Copy link
Contributor

trexfeathers commented May 4, 2021

To confirm my understanding:

We had another recent change to this image test in #40. This claimed to be for Matplotlib v3.4.1, but the CI has actually been running against Matplotlib v3.3.4 until more recently. Now that CI is running against v3.4.1, a further minor behaviour change can be seen, necessitating a further change to the test target.

On a different thread: I would prefer to see @rcomer's suggestion a reality, as this would indeed get things back to how they were before #40. I see now that I should not have merged #40; with no prior knowledge, I had assumed @bjlittle's change there was the closest we could get in the new world, but clearly I was wrong.

@rcomer
Copy link
Member

rcomer commented May 4, 2021

In fact, if I set linscale to 0.01, the gallery test passed 👍 . Got a bit confused about exactly what linscale does. I think the key thing is that the value is arbitrarily small.

@jamesp
Copy link
Member Author

jamesp commented May 4, 2021

Closing this issue as it's not the right fix! Let's open a separate PR on iris with @rcomer's suggested change above

@jamesp jamesp closed this May 4, 2021
@lbdreyer lbdreyer deleted the anomaly-plot branch June 8, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants