-
Notifications
You must be signed in to change notification settings - Fork 300
Convert tests/unit/mesh to PyTest.
#6631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6631 +/- ##
==========================================
+ Coverage 89.95% 90.00% +0.04%
==========================================
Files 91 91
Lines 24447 24447
Branches 4567 4567
==========================================
+ Hits 21992 22004 +12
+ Misses 1686 1676 -10
+ Partials 769 767 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ESadek-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you change the unittest.mock calls in test_MeshCoord?
Dir as a whole looks good, a couple of changes. There are one or two comments which are just comments, not change requests, feel free to resolve those once you've read them.
There're some massive files, which possibly haven't had great attention to detail from me, but I think it's 80 to 20.
|
Thanks @ESadek-MO, looks like a dropped the ball quite a bit there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more. Feel free to veto.
ESadek-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trexfeathers
test_MeshXYwas a mess (my fault originally. I've done my best to find a pattern that limits the changes, to help with reviewing.