Skip to content

Conversation

@trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Aug 11, 2025

test_MeshXY was a mess (my fault originally. I've done my best to find a pattern that limits the changes, to help with reviewing.

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (fee1d96) to head (d07705c).
⚠️ Report is 111 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6631      +/-   ##
==========================================
+ Coverage   89.95%   90.00%   +0.04%     
==========================================
  Files          91       91              
  Lines       24447    24447              
  Branches     4567     4567              
==========================================
+ Hits        21992    22004      +12     
+ Misses       1686     1676      -10     
+ Partials      769      767       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you change the unittest.mock calls in test_MeshCoord?

Dir as a whole looks good, a couple of changes. There are one or two comments which are just comments, not change requests, feel free to resolve those once you've read them.

There're some massive files, which possibly haven't had great attention to detail from me, but I think it's 80 to 20.

@trexfeathers
Copy link
Contributor Author

Thanks @ESadek-MO, looks like a dropped the ball quite a bit there.

Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more. Feel free to veto.

Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trexfeathers

@ESadek-MO ESadek-MO merged commit 7d223c9 into SciTools:main Aug 12, 2025
22 checks passed
@trexfeathers trexfeathers deleted the pytest_unit_mesh branch August 22, 2025 13:53
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants