Skip to content

Conversation

@trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented May 9, 2025

This has already been discussed on #6438, but I wanted to have a PR targetting v3.12.x as this makes the Git history less confusing.

@trexfeathers trexfeathers added this to the v3.12 milestone May 9, 2025
@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (8962e3b) to head (263704a).
⚠️ Report is 2 commits behind head on v3.12.x.

Files with missing lines Patch % Lines
lib/iris/fileformats/netcdf/saver.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           v3.12.x    #6451   +/-   ##
========================================
  Coverage    89.80%   89.80%           
========================================
  Files           90       90           
  Lines        23752    23752           
  Branches      4418     4418           
========================================
  Hits         21331    21331           
  Misses        1672     1672           
  Partials       749      749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bjlittle bjlittle self-requested a review May 9, 2025 10:55
@bjlittle bjlittle moved this to 👀 In Review in 🦔 v3.12.0 May 9, 2025
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trexfeathers Awesome, thanks!

LGTM 👍

@bjlittle bjlittle merged commit 9fbb360 into SciTools:v3.12.x May 9, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to 🏁 Done in 🦔 v3.12.0 May 9, 2025
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Jun 7, 2025
@trexfeathers trexfeathers deleted the fix-delayed-312 branch August 22, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

2 participants