[CI Bot] environment lockfiles auto-update #6330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
benchmark_this
Contributor
|
Man that was fast. The whole run took 80 seconds. Conda/Mamba have certainly improved over the last couple of years. |
trexfeathers
previously approved these changes
Feb 21, 2025
trexfeathers
dismissed
their stale review
I reviewed the changes and foolishly assumed the CI would pass!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6330 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 90 90
Lines 23447 23447
Branches 4361 4361
=======================================
Hits 21076 21076
Misses 1644 1644
Partials 727 727 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
The problem with the docstest is a bit of a mystery to me. Checking the difference between the built envs in the logs on a previous OK run (on #6327), it seems the only likely culprit is sphinx itself v 8.1.3 --> 8.2.0 But in that case I'm not quite sure why the docs build itself was OK. And if it's a problem with sphinx, or something subtle between latest sphinx and sphinxcontrib-apidoc, not sure how to address. |
Member
of course, one way would be to make this the time we try switching from "make doctest" to "pytest --doctest-modules" I've not really much idea how good that is, or how much work it would take |
Contributor
⏱️ Performance Benchmark Report: a541b38Performance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
⏱️ Performance Benchmark Report: a541b38Performance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
⏱️ Performance Benchmark Report: a541b38Performance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
Yes you're right, and we specifically chose to elevate warnings as the best way to capture badly-build documentation. Read the docs doesn't have this utility, which is why that check passed, but probably still encountered the same warning and may therefore have published documentation that is subtly wrong somewhere.
While I'm very keen for us to change both doctesting and link-checking to no longer rely on a docs build, we still need 1 docs build somewhere within GitHub Actions so that we can know when something isn't working perfectly. So this wouldn't be a solution. I will investigate in due course. Lock files mean we are protected from this in our other PRs for the time being. |
scitools-ci
bot
force-pushed
the
auto-update-lockfiles
branch
from
6e3530e to
809b94d
Compare
Contributor
⏱️ Performance Benchmark Report: 46a887fPerformance shiftsFull benchmark resultsGenerated by GHA run |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lockfiles updated to the latest resolvable environment.
If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.