Skip to content

Improve handling of masks in concatenate #6187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trexfeathers merged 2 commits into from
Oct 25, 2024
Merged

Improve handling of masks in concatenate #6187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e51588
Improve handling of masks
bouweandela Oct 24, 2024
b79bdde
Add whatsnew
bouweandela Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/whatsnew/latest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ This document explains the changes made to Iris for this release
may happen when there are very many or large auxiliary coordinates, derived
coordinates, cell measures, or ancillary variables to be checked that span
the concatenation axis. This issue can be avoided by disabling the
problematic check. (:pull:`5926`)
problematic check. (:pull:`5926` and :pull:`6187`)

🔥 Deprecations
===============
Expand Down
2 changes: 1 addition & 1 deletion lib/iris/_concatenate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def _hash_ndarray(a: np.ndarray) -> np.ndarray:

# Hash the bytes representing the array data.
hash.update(b"data=")
if isinstance(a, np.ma.MaskedArray):
if np.ma.is_masked(a):
# Hash only the unmasked data
hash.update(a.compressed().tobytes())
# Hash the mask
Expand Down
17 changes: 17 additions & 0 deletions lib/iris/tests/unit/concatenate/test_hashing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
(np.array([np.nan, 1.0]), np.array([np.nan, 1.0]), True),
(np.ma.array([1, 2], mask=[0, 1]), np.ma.array([1, 2], mask=[0, 1]), True),
(np.ma.array([1, 2], mask=[0, 1]), np.ma.array([1, 2], mask=[0, 0]), False),
(np.ma.array([1, 2], mask=[1, 1]), np.ma.array([1, 2], mask=[1, 1]), True),
(np.ma.array([1, 2], mask=[0, 0]), np.ma.array([1, 2], mask=[0, 0]), True),
(da.arange(6).reshape((2, 3)), da.arange(6, chunks=1).reshape((2, 3)), True),
(da.arange(20, chunks=1), da.arange(20, chunks=2), True),
(
Expand All @@ -33,6 +35,21 @@
da.ma.masked_array([1, 3], mask=[0, 1]),
True,
),
(
np.arange(2),
da.ma.masked_array(np.arange(2), mask=[0, 0]),
True,
),
(
np.arange(2),
da.ma.masked_array(np.arange(2), mask=[0, 1]),
False,
),
(
da.ma.masked_array(np.arange(10), mask=np.zeros(10)),
da.ma.masked_array(np.arange(10), mask=np.ma.nomask),
True,
),
(
np.ma.array([1, 2], mask=[0, 1]),
np.ma.array([1, 3], mask=[0, 1], fill_value=10),
Expand Down