"Fixed" benchmarks testing for changes in #6077 #6091
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move all iris.experimental.ugrid to iris.ugrid. Replace experiment.ugrid, including docstrings and imports. Fix test_ParseUgridOnLoad Fix ugrid.load. Remove PARSE_UGRID from t/i/ugrid/test_ugrid_save Remove PARSE_UGRID from t/u/ff/nc/saver/test_save Remove PARSE_UGRID from t/i/exp/geovista/(both) Remove PARSE_UGRID from t/u/tests/stock/test_netcdf * Adjust references in docs. * Fix type. * Workaround docs build problem. Include alternative index workaround. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix Mesh -> MeshXY in experimental.ugrid * Import annotations in new files. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Move all iris.experimental.ugrid to iris.ugrid. Replace experiment.ugrid, including docstrings and imports. Fix test_ParseUgridOnLoad Fix ugrid.load. Remove PARSE_UGRID from t/i/ugrid/test_ugrid_save Remove PARSE_UGRID from t/u/ff/nc/saver/test_save Remove PARSE_UGRID from t/i/exp/geovista/(both) Remove PARSE_UGRID from t/u/tests/stock/test_netcdf * Fix type of mesh in iris.tests.stock * Fix Mesh -> MeshXY in experimental.ugrid * Remove PARSE_UGRID_ON_LOAD and ParseUGridOnLoad, leave in iris.experimental.ugrid only. missed * Replace old-style mesh api in benchmarks. * Move misplaced test + fix obsolete PARSE_UGRID usage. * Minimal doctest fixes * Remove obsolete PARSE_UGRID in iris.ugrid * Move all ugrid.metadata into common.metadata. Removed obsolete tests.unit.metadata * Rename iris.ugrid to iris.mesh fix Fix iris.mesh import in tests/stock/__init__ * Move all iris.mesh.save into iris.fileformats.netcdf.save Fix experimental.ugrid import of save_mesh * Fix docs for iris.ugrid -> iris.mesh * Rename iris.mesh.mesh as iris.mesh.components * Tidy imports in experimental.ugrid * Rebrand so mesh.MeshXY is presented as experimental.ugrid.Mesh. * Move ugrid loading support code from iris.mesh to iris.netcdf, and its tests likewise * Fix circular import. * Move mesh.cf code into fileformats.cf, and tests likewise Fix imports in cf ugrid tests. * Reinclude mesh-load functions in iris.mesh; break circular imports * Small fixes to mesh documentation * Added whatsnew * Complete+remove remaining 'TODO's from SciTools#6061 * Odd docstring and comment corrections.
pp-mo
added
the
benchmark_this
Member
Author
|
(got this wrong : replaced) |
Contributor
⏱️ Performance Benchmark Report: 680eda3Performance shiftsFull benchmark resultsGenerated by GHA run |
Member
Author
|
Replaced by #6092 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## bmfixed_6077_BASIS #6091 +/- ##
======================================================
- Coverage 89.75% 89.75% -0.01%
======================================================
Files 90 88 -2
Lines 22981 22976 -5
Branches 5026 5022 -4
======================================================
- Hits 20627 20621 -6
Misses 1624 1624
- Partials 730 731 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trial for benchmarks run, since it looks like the benchmark code in #6077 won't run prior to #6077
(a mistake!)
So, this replaces tonight's overnight run on this, which we expect to fail.