Adding monthly and yearly arguments to guess_bounds
#6090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HGWright
changed the title
guess_bounds
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6090 +/- ##
==========================================
+ Coverage 89.75% 89.77% +0.01%
==========================================
Files 88 88
Lines 22976 23011 +35
Branches 5022 5032 +10
==========================================
+ Hits 20621 20657 +36
+ Misses 1624 1623 -1
Partials 731 731 ☔ View full report in Codecov by Sentry. |
pp-mo
requested changes
Jul 26, 2024
pp-mo
reviewed
Jul 26, 2024
pp-mo
requested changes
Jul 26, 2024
Member
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
This is cool, one slight improvement suggested.
But .. I think we need to error if both monthly + yearly are True.
And maybe a mention of that in the docstring too.
pp-mo
approved these changes
Jul 26, 2024
Member
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
Nice, I think this nails it all.
Good to have fixed on pytest now, I think -- a mixture of pytest + unittest is not so good !
stephenworsley
added a commit
to stephenworsley/iris
that referenced
this pull request
Jul 29, 2024
* main: Adding monthly and yearly arguments to `guess_bounds` (SciTools#6090)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Jul 30, 2024
* upstream/main: Load performance improvement (ignoring UGRID) (SciTools#6088) Adding monthly and yearly arguments to `guess_bounds` (SciTools#6090) Mesh nonexperimental extra (SciTools#6077) Mesh nonexperimental (SciTools#6061) Bump scitools/workflows from 2024.07.4 to 2024.07.5 (SciTools#6076) Updated environment lockfiles (SciTools#6068) Enable UGRID loading always; deprecate PARSE_UGRID_ON_LOAD. (SciTools#6054) Bump scitools/workflows from 2024.07.3 to 2024.07.4 (SciTools#6071)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Closes #4864
This adds the
monthlyandyearlyoptions toguess_bounds.Add any of the below labels to trigger actions on this PR: