Skip to content

Conversation

@trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

Part of the fix for #6029. Note that this change is also backwards compatible with earlier versions of GeoVista.


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@trexfeathers trexfeathers requested a review from pp-mo July 19, 2024 13:00
@trexfeathers trexfeathers changed the title Doctest compatibility with GeoVista v0.5. Doctest compatibility with GeoVista v0.5 Jul 19, 2024
@codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (bd66de9) to head (092705c).
Report is 60 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6064   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files          90       90           
  Lines       22996    22996           
  Branches     5032     5032           
=======================================
  Hits        20642    20642           
  Misses       1623     1623           
  Partials      731      731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pp-mo pp-mo merged commit c60afa8 into SciTools:main Jul 19, 2024
@pp-mo pp-mo linked an issue Jul 19, 2024 that may be closed by this pull request
2 tasks
tkknight added a commit to tkknight/iris that referenced this pull request Jul 21, 2024
* upstream/main:
  Updated environment lockfiles (SciTools#6029)
  Pin matplotlib != 3.9.1 (SciTools#6065)
  add location argument to mesh.coords (SciTools#6055)
  Doctest compatibility with GeoVista v0.5. (SciTools#6064)
  Rename `Mesh` to `MeshXY` (SciTools#6056)
  Bump scitools/workflows from 2024.07.2 to 2024.07.3 (SciTools#6063)
@trexfeathers trexfeathers deleted the geovista_0_5 branch August 22, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emerging CI problem with lockfile update

2 participants