Temporary fix for airspeed-velocity/asv#1396#5931
Merged
stephenworsley merged 2 commits intoSciTools:mainfrom Apr 29, 2024
Merged
Temporary fix for airspeed-velocity/asv#1396#5931stephenworsley merged 2 commits intoSciTools:mainfrom
stephenworsley merged 2 commits intoSciTools:mainfrom
Conversation
trexfeathers
added
the
benchmark_this
trexfeathers
added
benchmark_this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5931 +/- ##
==========================================
+ Coverage 89.76% 89.78% +0.01%
==========================================
Files 93 93
Lines 22982 23007 +25
Branches 5006 5017 +11
==========================================
+ Hits 20630 20657 +27
+ Misses 1622 1620 -2
Partials 730 730 ☔ View full report in Codecov by Sentry. |
Contributor
⏱️ Performance Benchmark Report: 28090ccPerformance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
⏱️ Performance Benchmark Report: 9a1b01fPerformance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
Author
|
Thanks @stephenworsley! |
This was referenced Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
See airspeed-velocity/asv#1396. The fix has been proposed in airspeed-velocity/asv#1397 but it is uncertain how quickly that might progress. We need the benchmarks working for an upcoming sprint, including in places where we cannot pin the Conda version appropriately, so I am proposing this temporary override in our existing subclass.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: