Skip to content

Conversation

@jfrost-mo
Copy link
Contributor

@jfrost-mo jfrost-mo commented Apr 2, 2024

🚀 Pull Request

Description

This makes the output of pytest on GitHub Actions much more readable by breaking it up with colour.

It has to be forced on as GitHub Actions doesn't use a real TTY, which pytest uses for rich output detection.


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

This makes the output much more readable. It has to be forced on as
GitHub Actions doesn't use a real TTY, which pytest uses for rich output
detection.
@jfrost-mo jfrost-mo marked this pull request as draft April 2, 2024 11:57
@CLAassistant
Copy link

CLAassistant commented Apr 2, 2024

CLA assistant check
All committers have signed the CLA.

@jfrost-mo jfrost-mo marked this pull request as ready for review April 2, 2024 12:13
@bjlittle bjlittle self-assigned this Apr 2, 2024
@bjlittle
Copy link
Member

bjlittle commented Apr 2, 2024

@jfrost-mo Do you fancy adding a whatsnew entry in the 💼 Internal section, thanks 👍

@codecov
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (375da2d) to head (a3a4d5d).
Report is 20 commits behind head on main.

❗ Current head a3a4d5d differs from pull request most recent head 8cb9a49. Consider uploading reports for the commit 8cb9a49 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5895      +/-   ##
==========================================
+ Coverage   89.73%   89.76%   +0.03%     
==========================================
  Files          92       93       +1     
  Lines       22898    22957      +59     
  Branches     5453     5466      +13     
==========================================
+ Hits        20547    20607      +60     
  Misses       1620     1620              
+ Partials      731      730       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfrost-mo Awesome! The color make a BIG difference, thanks! 💯

@bjlittle bjlittle merged commit 03a2d5c into SciTools:main Apr 2, 2024
tkknight added a commit to tkknight/iris that referenced this pull request Apr 3, 2024
* upstream/main: (163 commits)
  Restore latest Whats New files.
  Whats new updates for `v3.9.0rc0` (SciTools#5899)
  nep29: drop py39 and support py312 (SciTools#5894)
  Support NetCDF v3 files in chunking control code. (SciTools#5897)
  Avoid computing lazy scalar coordinates when printing a Cube (v2) (SciTools#5896)
  Force pytest colour output on GitHub Actions (SciTools#5895)
  Make typing 3.9 compatible.
  Improve typing readability.
  Updated environment lockfiles (SciTools#5892)
  [pre-commit.ci] pre-commit autoupdate
  What's New entry for SciTools#5740 .
  Iris to GeoVista conversion (SciTools#5740)
  Try Union for type hinting.
  Type hinting.
  Fix typo.
  Re-introduce backwards compatible warning.
  Updated documentation.
  Remove loose references to fill value warnings.
  Advertise structured_um_loading performance regression.
  [pre-commit.ci] pre-commit autoupdate
  ...
tkknight added a commit to tkknight/iris that referenced this pull request Apr 10, 2024
…th_numpydoc

* upstream/main: (39 commits)
  Bump scitools/workflows from 2024.03.3 to 2024.04.0 (SciTools#5907)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5906)
  Updated environment lockfiles (SciTools#5904)
  Ignore flaticon.com in linkchecks. (SciTools#5905)
  Implement lazy area weights (SciTools#5658)
  Add option to specify chunks in `iris.util.broadcast_to_shape` (SciTools#5620)
  Unpin sphinx (SciTools#5901)
  DOC: clarify save_pairs_from_cube docstring (SciTools#5783)
  Restore latest Whats New files.
  Whats new updates for `v3.9.0rc0` (SciTools#5899)
  nep29: drop py39 and support py312 (SciTools#5894)
  Support NetCDF v3 files in chunking control code. (SciTools#5897)
  Avoid computing lazy scalar coordinates when printing a Cube (v2) (SciTools#5896)
  Force pytest colour output on GitHub Actions (SciTools#5895)
  Make typing 3.9 compatible.
  Improve typing readability.
  Updated environment lockfiles (SciTools#5892)
  [pre-commit.ci] pre-commit autoupdate
  What's New entry for SciTools#5740 .
  Iris to GeoVista conversion (SciTools#5740)
  ...
@jfrost-mo jfrost-mo deleted the colourise_actions_pytest_output branch February 28, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants