Skip to content

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented Mar 11, 2024

No description provided.

@pp-mo pp-mo requested a review from bjlittle March 11, 2024 15:47
@pp-mo pp-mo changed the title Convert all tests to pytest. Convert tests.unit.concatenate.test_concantenate to pytest. Mar 11, 2024
@codecov
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (FEATURE_pytest_conversion@1ca9400). Click here to learn what that means.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             FEATURE_pytest_conversion    #5813   +/-   ##
============================================================
  Coverage                             ?   89.74%           
============================================================
  Files                                ?       92           
  Lines                                ?    22940           
  Branches                             ?     5462           
============================================================
  Hits                                 ?    20588           
  Misses                               ?     1620           
  Partials                             ?      732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle bjlittle self-assigned this Mar 11, 2024
@bjlittle
Copy link
Member

@pp-mo This pull-request is still in draft ... did you want me to hold off reviewing just now?

@pp-mo
Copy link
Member Author

pp-mo commented Mar 11, 2024

@pp-mo This pull-request is still in draft ... did you want me to hold off reviewing just now?

Not now it passes !
Knock yourself out ...

@pp-mo pp-mo marked this pull request as ready for review March 11, 2024 16:21
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pp-mo Lookin' good! 💯

Just a simple query to service then we can bank this 👍

Nice one!

@pp-mo pp-mo changed the base branch from main to FEATURE_pytest_conversion March 11, 2024 17:21
@pp-mo pp-mo linked an issue Mar 11, 2024 that may be closed by this pull request
5 tasks
@pp-mo pp-mo force-pushed the pytests_unit_concatenate__test_concatenate branch from d18c21d to a33a560 Compare March 11, 2024 17:28
@pp-mo pp-mo changed the title Convert tests.unit.concatenate.test_concantenate to pytest. Convert tests.unit.concatenate.test_concatenate to pytest. Mar 11, 2024
@pp-mo pp-mo force-pushed the pytests_unit_concatenate__test_concatenate branch from a33a560 to 0f36090 Compare March 11, 2024 17:32
@bjlittle bjlittle merged commit 9aaa71f into SciTools:FEATURE_pytest_conversion Mar 11, 2024
@bjlittle
Copy link
Member

@pp-mo Awesome, cheers 🍻

@trexfeathers trexfeathers added the Type: Feature Branch Highlight this for a feature branch label Mar 12, 2024
@pp-mo pp-mo deleted the pytests_unit_concatenate__test_concatenate branch November 29, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: pytest Type: Feature Branch Highlight this for a feature branch

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

Convert unit/concatenate test files to pytest

3 participants